From: Jakub Kicinski <kuba@kernel.org>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: Michael Chan <michael.chan@broadcom.com>,
<netdev@vger.kernel.org>, <edumazet@google.com>,
<pabeni@redhat.com>, <pavan.chebbi@broadcom.com>,
<andrew.gospodarek@broadcom.com>, <horms@kernel.org>,
<helgaas@kernel.org>, Vikas Gupta <vikas.gupta@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>, <davem@davemloft.net>
Subject: Re: [PATCH net-next v2 2/9] bnxt_en: add support for retrieving crash dump using ethtool
Date: Mon, 19 Aug 2024 18:41:40 -0700 [thread overview]
Message-ID: <20240819184140.1d38b98a@kernel.org> (raw)
In-Reply-To: <895f8e49-2bbd-4211-b1a5-6708956a580a@intel.com>
On Mon, 19 Aug 2024 12:12:39 +0200 Przemek Kitszel wrote:
> > + if (dump_type == BNXT_DUMP_CRASH &&
> > + bp->fw_dbg_cap & DBG_QCAPS_RESP_FLAGS_CRASHDUMP_HOST_DDR &&
>
> I would wrap bitwise-and with parenthesis, even if not mandated by the C
> standard (the same in other places with combined expressions).
Personal preference, I guess. I generally lean on the side of limiting
the brackets.
👍️ to other comments, thank for reviewing!
next prev parent reply other threads:[~2024-08-20 1:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 21:28 [PATCH net-next v2 0/9] bnxt_en: Update for net-next Michael Chan
2024-08-16 21:28 ` [PATCH net-next v2 1/9] bnxt_en: add support for storing crash dump into host memory Michael Chan
2024-08-19 10:00 ` Przemek Kitszel
2024-08-20 18:09 ` Michael Chan
2024-08-16 21:28 ` [PATCH net-next v2 2/9] bnxt_en: add support for retrieving crash dump using ethtool Michael Chan
2024-08-19 10:12 ` Przemek Kitszel
2024-08-20 1:41 ` Jakub Kicinski [this message]
2024-08-16 21:28 ` [PATCH net-next v2 3/9] bnxt_en: Support QOS and TPID settings for the SRIOV VLAN Michael Chan
2024-08-16 21:28 ` [PATCH net-next v2 4/9] bnxt_en: Deprecate support for legacy INTX mode Michael Chan
2024-08-19 9:17 ` Simon Horman
2024-08-16 21:28 ` [PATCH net-next v2 5/9] bnxt_en: Remove BNXT_FLAG_USING_MSIX flag Michael Chan
2024-08-16 21:28 ` [PATCH net-next v2 6/9] bnxt_en: Remove register mapping to support INTX Michael Chan
2024-08-16 21:28 ` [PATCH net-next v2 7/9] bnxt_en: Replace deprecated PCI MSIX APIs Michael Chan
2024-08-19 10:20 ` Przemek Kitszel
2024-08-16 21:28 ` [PATCH net-next v2 8/9] bnxt_en: Allocate the max bp->irq_tbl size for dynamic msix allocation Michael Chan
2024-08-19 10:31 ` Przemek Kitszel
2024-08-16 21:28 ` [PATCH net-next v2 9/9] bnxt_en: Support dynamic MSIX Michael Chan
2024-08-19 10:33 ` Przemek Kitszel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240819184140.1d38b98a@kernel.org \
--to=kuba@kernel.org \
--cc=andrew.gospodarek@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=helgaas@kernel.org \
--cc=horms@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=somnath.kotur@broadcom.com \
--cc=vikas.gupta@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.