From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andi Shyti <andi.shyti@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>,
Narasimhan.V@amd.com, Borislav Petkov <bp@alien8.de>,
Kim Phillips <kim.phillips@amd.com>,
Mario Limonciello <mario.limonciello@amd.com>
Subject: [PATCH v3 1/7] i2c: designware: Replace a while-loop by for-loop
Date: Mon, 19 Aug 2024 21:45:07 +0300 [thread overview]
Message-ID: <20240819184600.2256658-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20240819184600.2256658-1-andriy.shevchenko@linux.intel.com>
Replace a while-loop by for-loop in i2c_dw_probe_lock_support() to
save a few lines of code.
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/i2c/busses/i2c-designware-platdrv.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
index df3dc1e8093e..d092532375b8 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -238,11 +238,9 @@ static int i2c_dw_probe_lock_support(struct dw_i2c_dev *dev)
int i = 0;
int ret;
- ptr = i2c_dw_semaphore_cb_table;
-
dev->semaphore_idx = -1;
- while (ptr->probe) {
+ for (ptr = i2c_dw_semaphore_cb_table; ptr->probe; ptr++) {
ret = ptr->probe(dev);
if (ret) {
/*
@@ -254,7 +252,6 @@ static int i2c_dw_probe_lock_support(struct dw_i2c_dev *dev)
return ret;
i++;
- ptr++;
continue;
}
--
2.43.0.rc1.1336.g36b5255a03ac
next prev parent reply other threads:[~2024-08-19 18:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 18:45 From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Andy Shevchenko
2024-08-19 18:45 ` Andy Shevchenko [this message]
2024-08-19 18:45 ` [PATCH v3 2/7] i2c: designware: Let PCI core to take care about interrupt vectors Andy Shevchenko
2024-08-20 11:15 ` Jarkko Nikula
2024-08-19 18:45 ` [PATCH v3 3/7] i2c: designware: Add missing 'c' into PCI IDs variable name Andy Shevchenko
2024-08-19 18:45 ` [PATCH v3 4/7] i2c: designware: Unify terminator in device ID tables Andy Shevchenko
2024-08-19 18:45 ` [PATCH v3 5/7] i2c: designware: Always provide " Andy Shevchenko
2024-08-19 18:45 ` [PATCH v3 6/7] i2c: designware: Drop return value from i2c_dw_acpi_configure() Andy Shevchenko
2024-08-19 18:45 ` [PATCH v3 7/7] i2c: designware: Drop return value from dw_i2c_of_configure() Andy Shevchenko
2024-08-19 20:27 ` From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Andi Shyti
2024-08-21 14:11 ` Andi Shyti
2024-08-21 14:15 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240819184600.2256658-2-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Narasimhan.V@amd.com \
--cc=andi.shyti@kernel.org \
--cc=bp@alien8.de \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=kim.phillips@amd.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.