From: Christian Brauner <brauner@kernel.org>
To: NeilBrown <neilb@suse.de>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 4/9] Use wait_var_event() instead of I_DIO_WAKEUP
Date: Tue, 20 Aug 2024 21:12:08 +0200 [thread overview]
Message-ID: <20240820-rache-gerochen-aad94052320e@brauner> (raw)
In-Reply-To: <20240820-ausschalten-lider-e30db5ffbde3@brauner>
On Tue, Aug 20, 2024 at 09:22:33AM GMT, Christian Brauner wrote:
> On Mon, Aug 19, 2024 at 03:20:38PM GMT, NeilBrown wrote:
> > inode_dio_wait() is essentially an open-coded version of
> > wait_var_event(). Similarly inode_dio_wait_interruptible() is an
> > open-coded version of wait_var_event_interruptible().
> >
> > If we switch to waiting on the var, instead of an imaginary bit, the
> > code is more transparent, is shorter, and we can discard I_DIO_WAKEUP.
> >
> > Signed-off-by: NeilBrown <neilb@suse.de>
> > ---
>
> Neil, I've sent a patch for this last week already removing
> __I_DIO_WAKEUP and it's in -next as
> 0009dc756e81 ("inode: remove __I_DIO_WAKEUP"). So you can drop this
Today's the day of getting things slightly wrong it seems...
2726a7a8477d8c0 is what I meant.
next prev parent reply other threads:[~2024-08-20 19:12 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 5:20 [PATCH 0/9 RFC] Make wake_up_{bit,var} less fragile NeilBrown
2024-08-19 5:20 ` [PATCH 1/9] i915: remove wake_up on I915_RESET_MODESET NeilBrown
2024-08-19 5:20 ` [PATCH 2/9] Introduce atomic_dec_and_wake_up_var() NeilBrown
2024-08-20 5:47 ` kernel test robot
2024-08-21 5:23 ` kernel test robot
2024-08-19 5:20 ` [PATCH 3/9] XFS: use wait_var_event() when waiting of i_pincount NeilBrown
2024-08-19 5:20 ` [PATCH 4/9] Use wait_var_event() instead of I_DIO_WAKEUP NeilBrown
2024-08-20 7:22 ` Christian Brauner
2024-08-20 19:12 ` Christian Brauner [this message]
2024-08-19 5:20 ` [PATCH 5/9] Block: switch bd_prepare_to_claim to use ___wait_var_event() NeilBrown
2024-08-20 4:18 ` Dave Chinner
2024-08-20 21:52 ` NeilBrown
2024-08-28 1:22 ` Dave Chinner
2024-08-28 5:20 ` NeilBrown
2024-08-20 11:40 ` Hillf Danton
2024-08-21 7:10 ` kernel test robot
2024-08-19 5:20 ` [PATCH 6/9] block/pktdvd: switch congestion waiting to ___wait_var_event() NeilBrown
2024-08-19 5:20 ` [PATCH 7/9] Improve and expand wake_up_bit() interface NeilBrown
2024-08-19 5:20 ` [PATCH 8/9] Improve and extend wake_up_var() interface NeilBrown
2024-08-19 5:20 ` [PATCH 9/9] Use clear_and_wake_up_bit() where appropriate NeilBrown
2024-08-19 6:13 ` [PATCH 0/9 RFC] Make wake_up_{bit,var} less fragile Linus Torvalds
2024-08-20 21:47 ` NeilBrown
2024-08-20 21:58 ` Linus Torvalds
2024-08-20 22:15 ` NeilBrown
2024-08-20 22:24 ` Linus Torvalds
2024-08-19 8:16 ` Christian Brauner
2024-08-19 17:45 ` Linus Torvalds
2024-08-19 20:52 ` NeilBrown
2024-08-19 21:12 ` Linus Torvalds
2024-08-20 16:06 ` [PATCH RFC 0/5] inode: turn i_state into u32 Christian Brauner
2024-08-20 16:06 ` [PATCH RFC 1/5] fs: add i_state helpers Christian Brauner
2024-08-20 17:10 ` Linus Torvalds
2024-08-20 17:19 ` Linus Torvalds
2024-08-20 19:10 ` Christian Brauner
2024-08-20 19:08 ` Christian Brauner
2024-08-20 16:06 ` [PATCH RFC 2/5] writeback: port __I_SYNC to var event Christian Brauner
2024-08-20 16:06 ` [PATCH RFC 3/5] inode: port __I_NEW " Christian Brauner
2024-08-20 16:06 ` [PATCH RFC 4/5] inode: port __I_LRU_ISOLATING " Christian Brauner
2024-08-20 16:06 ` [PATCH RFC 5/5] inode: make i_state a u32 Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240820-rache-gerochen-aad94052320e@brauner \
--to=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=neilb@suse.de \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.