From: Dmitry Kandybka <d.kandybka@gmail.com>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org,
Dmitry Antipov <dmantipov@yandex.ru>
Subject: [PATCH] wifi: rtw88: coex: remove rf4ce unused code
Date: Tue, 20 Aug 2024 08:52:44 +0300 [thread overview]
Message-ID: <20240820055244.128644-1-d.kandybka@gmail.com> (raw)
In 'rtw_coex_run_coex', 'rf4ce_en' is hardcoded to false,
so 'rtw_coex_action_rf4ce(rtwdev)' is never executed.
Assuming that rf4ce was never fully implemented,
remove lookalike leftovers. Compile tested only.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: a9359faaa47d ("rtw88: coex: add the mechanism for RF4CE")
Signed-off-by: Dmitry Kandybka <d.kandybka@gmail.com>
---
drivers/net/wireless/realtek/rtw88/coex.c | 30 +----------------------
1 file changed, 1 insertion(+), 29 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw88/coex.c b/drivers/net/wireless/realtek/rtw88/coex.c
index de3332eb7a22..1fbcf701e7b7 100644
--- a/drivers/net/wireless/realtek/rtw88/coex.c
+++ b/drivers/net/wireless/realtek/rtw88/coex.c
@@ -1591,31 +1591,6 @@ static void rtw_coex_action_freerun(struct rtw_dev *rtwdev)
rtw_coex_tdma(rtwdev, false, 100);
}
-static void rtw_coex_action_rf4ce(struct rtw_dev *rtwdev)
-{
- const struct rtw_chip_info *chip = rtwdev->chip;
- struct rtw_efuse *efuse = &rtwdev->efuse;
- u8 table_case, tdma_case;
-
- rtw_dbg(rtwdev, RTW_DBG_COEX, "[BTCoex], %s()\n", __func__);
-
- rtw_coex_set_ant_path(rtwdev, false, COEX_SET_ANT_2G);
- rtw_coex_set_rf_para(rtwdev, chip->wl_rf_para_rx[0]);
-
- if (efuse->share_ant) {
- /* Shared-Ant */
- table_case = 9;
- tdma_case = 16;
- } else {
- /* Non-Shared-Ant */
- table_case = 100;
- tdma_case = 100;
- }
-
- rtw_coex_table(rtwdev, false, table_case);
- rtw_coex_tdma(rtwdev, false, tdma_case);
-}
-
static void rtw_coex_action_bt_whql_test(struct rtw_dev *rtwdev)
{
const struct rtw_chip_info *chip = rtwdev->chip;
@@ -2531,7 +2506,6 @@ static void rtw_coex_run_coex(struct rtw_dev *rtwdev, u8 reason)
struct rtw_coex *coex = &rtwdev->coex;
struct rtw_coex_dm *coex_dm = &coex->dm;
struct rtw_coex_stat *coex_stat = &coex->stat;
- bool rf4ce_en = false;
lockdep_assert_held(&rtwdev->mutex);
@@ -2587,9 +2561,7 @@ static void rtw_coex_run_coex(struct rtw_dev *rtwdev, u8 reason)
coex_stat->wl_coex_mode = COEX_WLINK_2G1PORT;
if (coex_stat->bt_disabled) {
- if (coex_stat->wl_connected && rf4ce_en)
- rtw_coex_action_rf4ce(rtwdev);
- else if (!coex_stat->wl_connected)
+ if (!coex_stat->wl_connected)
rtw_coex_action_wl_not_connected(rtwdev);
else
rtw_coex_action_wl_only(rtwdev);
--
2.43.5
next reply other threads:[~2024-08-20 5:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 5:52 Dmitry Kandybka [this message]
2024-10-10 8:19 ` [PATCH] wifi: rtw88: coex: remove rf4ce unused code Dmitry Kandybka
2024-10-11 0:26 ` Ping-Ke Shih
2024-10-11 6:45 ` Dmitry Kandybka
2024-10-15 9:59 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240820055244.128644-1-d.kandybka@gmail.com \
--to=d.kandybka@gmail.com \
--cc=dmantipov@yandex.ru \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.