All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [BUG] tracing: dynamic ftrace selftest detected failures
Date: Tue, 20 Aug 2024 10:03:30 +0900	[thread overview]
Message-ID: <20240820100330.9ee6f3d51f22bb9bab7c4b83@kernel.org> (raw)
In-Reply-To: <20240819120244.5657eb2f@gandalf.local.home>

On Mon, 19 Aug 2024 12:02:44 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue, 20 Aug 2024 00:56:49 +0900
> Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> > 
> > > 
> > > We may need to add "noinline" or something to make sure those functions
> > > don't get inlined for LTO.  
> > 
> > Yeah, we need such option at least for function call test.
> 
> Could you add the noinline, and if it fixes the issue send a patch?

I found the target function already has "noinline". I tried to add noinline
to the testing function (callsite), but it also did not work.
I think "noinline" is for the compiler, but LTO is done by the linker.

I found a discussion similar to this problem, but it seems very hacky.

https://groups.google.com/g/llvm-dev/c/6baI9LISmSU/m/uEeY_CRbBQAJ?pli=1

Thank you,

> 
> Thanks,
> 
> -- Steve
> 


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>

  parent reply	other threads:[~2024-08-20  1:03 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-19  8:11 [BUG] tracing: dynamic ftrace selftest detected failures Masami Hiramatsu
2024-08-19 15:29 ` Steven Rostedt
2024-08-19 15:56   ` Masami Hiramatsu
2024-08-19 16:02     ` Steven Rostedt
2024-08-19 23:34       ` Masami Hiramatsu
2024-08-20  1:03       ` Masami Hiramatsu [this message]
2024-08-20 10:48         ` Mark Rutland
2024-08-20 13:56           ` Steven Rostedt
2024-08-20 15:10           ` Sami Tolvanen
2024-08-20 15:20             ` Steven Rostedt
2024-08-20 22:05             ` Masami Hiramatsu
2024-08-20 22:11               ` Steven Rostedt
2024-08-20 23:43                 ` Masami Hiramatsu
2024-08-20 23:49                   ` Steven Rostedt
2024-08-21  0:15                     ` Masami Hiramatsu
2024-08-21  0:21                   ` Masami Hiramatsu
2024-08-21 15:06                     ` Sami Tolvanen
2024-08-21 15:32               ` Mark Rutland
2024-08-21 15:42                 ` Mark Rutland
2024-08-21 15:50                   ` Steven Rostedt
2024-08-23  0:04                     ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240820100330.9ee6f3d51f22bb9bab7c4b83@kernel.org \
    --to=mhiramat@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.