From: Jakub Kicinski <kuba@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jonathan Corbet <corbet@lwn.net>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH net-next v2 1/3] ethtool: Extend cable testing interface with result source information
Date: Tue, 20 Aug 2024 15:01:47 -0700 [thread overview]
Message-ID: <20240820150147.1fdae1ac@kernel.org> (raw)
In-Reply-To: <20240820101256.1506460-2-o.rempel@pengutronix.de>
On Tue, 20 Aug 2024 12:12:54 +0200 Oleksij Rempel wrote:
> + -
> + name: src
> + type: u8
If you have to respin please s/u8/u32/
Netlink rounds up all fields sizes to u32, u8 ends up being the same
size as u32 "on the wire" but 3 out of the 4 bytes are unusable.
next prev parent reply other threads:[~2024-08-20 22:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 10:12 [PATCH net-next v2 0/3] Add ALCD Support to Cable Testing Interface Oleksij Rempel
2024-08-20 10:12 ` [PATCH net-next v2 1/3] ethtool: Extend cable testing interface with result source information Oleksij Rempel
2024-08-20 16:40 ` Andrew Lunn
2024-08-20 22:01 ` Jakub Kicinski [this message]
2024-08-20 10:12 ` [PATCH net-next v2 2/3] ethtool: Add support for specifying information source in cable test results Oleksij Rempel
2024-08-20 16:44 ` Andrew Lunn
2024-08-20 10:12 ` [PATCH net-next v2 3/3] phy: dp83td510: Utilize ALCD for cable length measurement when link is active Oleksij Rempel
2024-08-20 16:49 ` Andrew Lunn
2024-08-20 17:59 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240820150147.1fdae1ac@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.