From: Jakub Kicinski <kuba@kernel.org>
To: Nikolay Kuratov <kniv@yandex-team.ru>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
stable@vger.kernel.org, lvc-project@linuxtesting.org,
Kumar Sanghvi <kumaras@chelsio.com>,
Potnuri Bharat Teja <bharat@chelsio.com>,
Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
Ganesh Goudar <ganeshgr@chelsio.com>,
"David S. Miller" <davem@davemloft.net>,
Simon Horman <horms@kernel.org>
Subject: Re: [PATCH v2] cxgb4: add forgotten u64 ivlan cast before shift
Date: Tue, 20 Aug 2024 15:44:50 -0700 [thread overview]
Message-ID: <20240820154450.4a37077e@kernel.org> (raw)
In-Reply-To: <20240819075408.92378-1-kniv@yandex-team.ru>
On Mon, 19 Aug 2024 10:54:08 +0300 Nikolay Kuratov wrote:
> It is done everywhere in cxgb4 code, e.g. in is_filter_exact_match()
> There is no reason it should not be done here
The max value of the shift is 21. I wish you spent more than 5 min
looking at this code.
next prev parent reply other threads:[~2024-08-20 22:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 7:54 [PATCH v2] cxgb4: add forgotten u64 ivlan cast before shift Nikolay Kuratov
2024-08-20 21:41 ` Jacob Keller
2024-08-20 22:44 ` Jakub Kicinski [this message]
2024-08-20 22:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240820154450.4a37077e@kernel.org \
--to=kuba@kernel.org \
--cc=bharat@chelsio.com \
--cc=davem@davemloft.net \
--cc=ganeshgr@chelsio.com \
--cc=horms@kernel.org \
--cc=kniv@yandex-team.ru \
--cc=kumaras@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=rahul.lakkireddy@chelsio.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.