From: "Darrick J. Wong" <djwong@kernel.org>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: linux-doc@vger.kernel.org, corbet@lwn.net, jack@suse.cz,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
kernel-dev@igalia.com, kernel@gpiccoli.net
Subject: Re: [PATCH] Documentation: Document the kernel flag bdev_allow_write_mounted
Date: Tue, 20 Aug 2024 09:23:59 -0700 [thread overview]
Message-ID: <20240820162359.GI6043@frogsfrogsfrogs> (raw)
In-Reply-To: <20240819225626.2000752-2-gpiccoli@igalia.com>
On Mon, Aug 19, 2024 at 07:56:27PM -0300, Guilherme G. Piccoli wrote:
> Commit ed5cc702d311 ("block: Add config option to not allow writing to mounted
> devices") added a Kconfig option along with a kernel command-line tuning to
> control writes to mounted block devices, as a means to deal with fuzzers like
> Syzkaller, that provokes kernel crashes by directly writing on block devices
> bypassing the filesystem (so the FS has no awareness and cannot cope with that).
>
> The patch just missed adding such kernel command-line option to the kernel
> documentation, so let's fix that.
>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
> ---
> Documentation/admin-guide/kernel-parameters.txt | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 09126bb8cc9f..709d1ee342db 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -517,6 +517,16 @@
> Format: <io>,<irq>,<mode>
> See header of drivers/net/hamradio/baycom_ser_hdx.c.
>
> + bdev_allow_write_mounted=
> + Format: <bool>
> + Control the ability of directly writing to mounted block
> + devices' page cache, i.e., allow / disallow writes that
> + bypasses the FS. This was implemented as a means to
> + prevent fuzzers to crash the kernel by breaking the
> + filesystem without its awareness, through direct block
> + device writes. Default is Y and can be changed through
> + the Kconfig option CONFIG_BLK_DEV_WRITE_MOUNTED.
Can we mention that this also solves the problem of naïve storage
management tools (aka the ones that don't use O_EXCL) writing over a
mounted filesystem and trashing it?
--D
> +
> bert_disable [ACPI]
> Disable BERT OS support on buggy BIOSes.
>
> --
> 2.45.2
>
>
next prev parent reply other threads:[~2024-08-20 16:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 22:56 [PATCH] Documentation: Document the kernel flag bdev_allow_write_mounted Guilherme G. Piccoli
2024-08-20 16:23 ` Darrick J. Wong [this message]
2024-08-20 18:42 ` Guilherme G. Piccoli
2024-08-23 1:27 ` Darrick J. Wong
2024-08-23 14:29 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240820162359.GI6043@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=corbet@lwn.net \
--cc=gpiccoli@igalia.com \
--cc=jack@suse.cz \
--cc=kernel-dev@igalia.com \
--cc=kernel@gpiccoli.net \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.