From: Simon Horman <horms@kernel.org>
To: Bharat Bhushan <bharatb.linux@gmail.com>
Cc: Bharat Bhushan <bbhushan2@marvell.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com,
hkelam@marvell.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, jerinj@marvell.com,
lcherian@marvell.com, ndabilpuram@marvell.com
Subject: Re: [net PATCH v2] octeontx2-af: Fix CPT AF register offset calculation
Date: Tue, 20 Aug 2024 19:33:35 +0100 [thread overview]
Message-ID: <20240820183335.GB2898@kernel.org> (raw)
In-Reply-To: <CAAeCc_ngtvx7LNWB2CMgfA6Vyitx8BTZbahJby+ZDgTEC5JYbA@mail.gmail.com>
On Tue, Aug 20, 2024 at 04:37:02PM +0530, Bharat Bhushan wrote:
> On Mon, Aug 19, 2024 at 8:57 PM Simon Horman <horms@kernel.org> wrote:
> >
> > On Mon, Aug 19, 2024 at 06:02:37PM +0530, Bharat Bhushan wrote:
> > > Some CPT AF registers are per LF and others are global.
> > > Translation of PF/VF local LF slot number to actual LF slot
> > > number is required only for accessing perf LF registers.
> > > CPT AF global registers access do not require any LF
> > > slot number.
> > >
> > > Also there is no reason CPT PF/VF to know actual lf's register
> > > offset.
> > >
> > > Fixes: bc35e28af789 ("octeontx2-af: replace cpt slot with lf id on reg write")
> > > Signed-off-by: Bharat Bhushan <bbhushan2@marvell.com>
> > > ---
> >
> > Hi Bharat,
> >
> > It would be very nice to have links (to lore) to earlier version and
> > descriptions of what has changed between versions here.
>
> Hi Simon,
>
> Will add below in next version of this patch
Thanks, much appreciated.
> v3:
> - Updated patch description about what's broken without this fix
> - Added patch history
>
> v2: https://lore.kernel.org/netdev/20240819152744.GA543198@kernel.org/T/
> - Spelling fixes in patch description
>
> v1: https://lore.kernel.org/lkml/CAAeCc_nJtR2ryzoaXop8-bbw_0RGciZsniiUqS+NVMg7dHahiQ@mail.gmail.com/T/
> - Added "net" in patch subject prefix, missed in previous patch:
> https://lore.kernel.org/lkml/20240806070239.1541623-1-bbhushan2@marvell.com/
>
>
> Thanks
> -Bharat
>
> >
> > Using b4 to manage patch submissions will help with this.
> >
>
next prev parent reply other threads:[~2024-08-20 18:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 12:32 [net PATCH v2] octeontx2-af: Fix CPT AF register offset calculation Bharat Bhushan
2024-08-19 15:27 ` Simon Horman
2024-08-20 11:07 ` Bharat Bhushan
2024-08-20 18:33 ` Simon Horman [this message]
2024-08-20 0:28 ` Jakub Kicinski
2024-08-20 11:05 ` Bharat Bhushan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240820183335.GB2898@kernel.org \
--to=horms@kernel.org \
--cc=bbhushan2@marvell.com \
--cc=bharatb.linux@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ndabilpuram@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.