Re: [OE-core][PATCH v2] piglit: upgrade 22eaf6a91c -> c11c9374c1

[Alexandre Belloni <alexandre.belloni@bootlin.com>]

There were other build failures:

https://autobuilder.yoctoproject.org/typhoon/#/builders/117/builds/5211/steps/13/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/9395/steps/11/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/45/builds/9407/steps/11/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/9226/steps/11/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/108/builds/6299/steps/12/logs/stdio

On 20/08/2024 14:39:16-0400, Trevor Gamblin wrote:
> 
> On 2024-08-20 1:24 p.m., Alexander Kanavin wrote:
> > I looked. There is a condition:
> > 
> > https://gitlab.freedesktop.org/mesa/piglit/-/blob/main/CMakeLists.txt?ref_type=heads#L108
> > 
> > if(PIGLIT_USE_X11)
> > find_package(X11 REQUIRED)
> > set(PIGLIT_HAS_X11 True)
> > add_definitions(-DPIGLIT_HAS_X11)
> > endif()
> 
> Changing the x11 PACKAGECONFIG line to this seems to work:
> 
> PACKAGECONFIG[x11] = "-DPIGLIT_USE_X11=1 -DPIGLIT_BUILD_GL_TESTS=ON
> -PIGLIT_BUILD_DMA_BUF_TESTS=ON,-DPIGLIT_USE_X11=0
> -DPIGLIT_BUILD_GL_TESTS=OFF -DPIGLIT_BUILD_DMA_BUF_TESTS=OFF,${X11_DEPS},
> ${X11_RDEPS}"
> 
> Is there a cleaner way to do this?
> 
> > 
> > Alex
> > 
> > On Tue, 20 Aug 2024 at 19:22, Alexander Kanavin via
> > lists.openembedded.org <alex.kanavin=gmail.com@lists.openembedded.org>
> > wrote:
> > > On Tue, 20 Aug 2024 at 19:18, Trevor Gamblin via
> > > lists.openembedded.org <tgamblin=baylibre.com@lists.openembedded.org>
> > > wrote:
> > > > 
> > > > On 2024-08-20 12:24 p.m., Alexandre Belloni wrote:
> > > > 
> > > > Unfortunately, this doesn't build on the AB:
> > > > 
> > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/9383/steps/11/logs/stdio
> > > > 
> > > > Seems to be because of this line in the config:
> > > > 
> > > > DISTRO_FEATURES:remove = 'x11'
> > > > 
> > > > I see that consolekit has REQUIRED_DISTRO_FEATURES = "x11" in the recipe. Is this the right approach then for piglit?
> > > Only if the X11 support is unconditional. You first need to look at
> > > the failure log that says:
> > > 
> > > |   Could NOT find X11 (missing: X11_X11_INCLUDE_PATH X11_X11_LIB)
> > > 
> > > And then check piglit source code and its cmake configuration files to
> > > see where that particular check is performed and whether it's wrapped
> > > into a condition that we can tweak via cmake subject to x11 in
> > > DISTRO_FEATURES.
> > > 
> > > Alex
> > > 
> > > -=-=-=-=-=-=-=-=-=-=-=-
> > > Links: You receive all messages sent to this group.
> > > View/Reply Online (#203561): https://lists.openembedded.org/g/openembedded-core/message/203561
> > > Mute This Topic: https://lists.openembedded.org/mt/107914101/1686489
> > > Group Owner: openembedded-core+owner@lists.openembedded.org
> > > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> > > -=-=-=-=-=-=-=-=-=-=-=-
> > > 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com