From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6D5C1B81BF; Wed, 21 Aug 2024 07:41:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724226119; cv=none; b=qA/JYTJGEBrNsbblh8jwG5dKWmM6FhLPmhLCm7SSwD/IVWADbfp8xEgua46c24/mde44C3IvKf7oxioNFT/Diftl4r3TFvytEDPQHyrYTlASHEo4Xty0pzZW8SlrSCUozFpoE3IrkI7m4wZyt6vP5ZiXnmtvy8YvTWTJJNxKl+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724226119; c=relaxed/simple; bh=aBgDAZ4ze0w4LhExDuXGPmQBmtP78IvFLVDICKsRhxk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mqPobWF3lY7gmB66airMdGdoGt0WNKrQ1cI7MNrRhnPgwDLhTHyFfh7qNkf7Y9kbD5mrzDTvzk0SpoXXrRmHC1KF+x1gOmDAHospQMNxTqrUcN3qhOPbN7euWeuTWYrhPFBUtEeROXmfHmDI2j8Hi/gX4gGWQ5l8/Tsh9BQQT70= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=ptK8mW9U; arc=none smtp.client-ip=217.70.183.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="ptK8mW9U" Received: by mail.gandi.net (Postfix) with ESMTPSA id 6544F1BF203; Wed, 21 Aug 2024 07:41:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1724226114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cNVE1Euex1vHgd16nkcpKWq4uCJnI5txc/wed22g5ng=; b=ptK8mW9UZGOaggQGmNwz0GVW3ar1qMYjrhdzLxxeT0cZmtOUj+Yfann9zwjzSeYDpICP4a wkqW6yljlgDLZcm+YmfuYK8oFEa/uWDIdgPkrqJw1CBCbdJN5h/y+FWiy7YM1wBv+6/5kJ qPtCIUCjzaZI760eRAQHhH5qJqcR6DHTcWSuMvAvWd3rYETUkR3izusP5EHYmW9HyZkNAM MT3AoU9azucVdMJA9a7ZqtFl0WTW2ruP0EiftemmT7B3syAOpDpaCTsDkaWPejC0Y+fVQc u35aozbT8wXo8FJqb8E1oPgteuMyxcjIM+TD702CPRB9aivYSHNMPr1MZZO3eQ== Date: Wed, 21 Aug 2024 09:41:50 +0200 From: Miquel Raynal To: Conor Dooley Cc: Thomas Bonnefille , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen Wang , Inochi Amaoto , Paul Walmsley , Palmer Dabbelt , Albert Ou , Thomas Petazzoni , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v4 1/3] dt-bindings: iio: adc: sophgo,cv18xx-saradc.yaml: Add Sophgo CV18XX SARADC binding Message-ID: <20240821094150.5787905b@xps-13> In-Reply-To: <20240820-borough-latch-17d785301aef@spud> References: <20240812-sg2002-adc-v4-0-599bdb67592f@bootlin.com> <20240812-sg2002-adc-v4-1-599bdb67592f@bootlin.com> <20240812-unwary-mongrel-9f6758bf624c@spud> <89aabfbe-79bf-4da7-be44-b6cbd92b72a9@bootlin.com> <20240820-borough-latch-17d785301aef@spud> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Hello, > > > > + Represents the channels of the ADC. > > > > + > > > > + properties: > > > > + reg: > > > > + description: | > > > > + The channel number. It can have up to 3 channels numbere= d from 0 to 2. > > > > + items: > > > > + - minimum: 0 > > > > + maximum: 2 =20 > > >=20 > > > Is this sufficient to limit the number of channels to 3? Aren't you r= elying > > > on the unique unit addresses warning in dtc to limit it, rather than > > > actually limiting with min/maxItems? > > > =20 > > It seems like I can't use min/maxItems on this property. I think that i= t is > > using size-cells + address-cells to deduce that the number of items sho= uld > > be equal to 1. =20 Looking at dt-schema, I couldn't personally understand from where did the error messages reported by Thomas came from. There are clear constraints over minItems/maxItems regarding the use of {#address-cells, #sizez-cells} being {1, 1}, {2, 2} and {2, 1} (in reg.yaml), but nothing explicit regarding the other situations, namely {1, 0} in this case which enforces maxItems to 1 is not clearly stated in any of the core yaml files. Any idea where to look at? Although, I'm convinced there is something defined because renaming the property from 'reg' to 'foo' silences these warnings. > I think I was mistaken in talking about mix/max items here. I had the > right idea, but mentioned an incorrect solution - sorry about that. I > wasn't talking about the number of elements in the reg property, what I > meant was limiting the number of channel nodes in the first place - > something which min/maxItems cannot do. As examples of the problem I was > thinking of, see the below two examples: >=20 > adc@30f0000 { > compatible =3D "sophgo,cv1800b-saradc"; > reg =3D <0x030f0000 0x1000>; > clocks =3D <&clk CLK_SARADC>; > interrupts =3D <100 IRQ_TYPE_LEVEL_HIGH>; > #address-cells =3D <1>; > #size-cells =3D <0>; >=20 > channel@0 { > reg =3D <0>; > }; > channel@2 { > reg =3D <2>; > }; > channel@22 { > reg =3D <2>; > }; > }; >=20 > adc@30f0000 { > compatible =3D "sophgo,cv1800b-saradc"; > reg =3D <0x030f0000 0x1000>; > clocks =3D <&clk CLK_SARADC>; > interrupts =3D <100 IRQ_TYPE_LEVEL_HIGH>; > #address-cells =3D <1>; > #size-cells =3D <0>; >=20 > channel@0 { > reg =3D <0>; > }; > channel@2 { > reg =3D <2>; > }; > channel@22 { > reg =3D <2>; > }; > }; >=20 > The solution is simple, remove the + from the regex. Sorry for sending > you on the wrong track Thomas. Ah! Thanks Conor for the details, now it makes full sense :-) BTW Thomas the regex is ^channel@[0-3]+$ and I guess it should instead be ^channel@[0-2]$ ^ in order to fully match the real indexing constraints you're enforcing with minimum/maximum. Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73DADC52D6F for ; Wed, 21 Aug 2024 07:42:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mI4Vzlzu9oraDBFZKUwu2KNXa3ZPG4lYnpTyX/I1mnM=; b=OD+LGQHdOuh0dn 6efLhAWt3SpuskZZD27a/jcSuXf8aEm4h7jIz9i5kst9m+18SMWICEeVZs1cZt53uB9R4Nc/ObpKN FEPHBxkmPZqSuziP01SOMgf2OynuITZTMCWLmfySuv1cAnB8C7q1jtOSq80XfeC8emxuuPr68Hyyf 32hm3BDsES2pf/EukwnhkNd7PV3I28WqfEQlPYAfKZSos/YrMXuy3xv5q31LD8MdQ6EBb1gOwhmnx yh8ZuJHoXpmpznQQm1t2PUnn/HP+LcVvQ7M9OS6YPa+MGdv9M58aNvV5hjGJWaXCcelEpqUiTvlFf Mpwh/T2ShOieBlsiAECg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgfyj-00000007xBT-2nu4; Wed, 21 Aug 2024 07:42:01 +0000 Received: from relay8-d.mail.gandi.net ([2001:4b98:dc4:8::228]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgfyg-00000007xAa-07T5 for linux-riscv@lists.infradead.org; Wed, 21 Aug 2024 07:42:00 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 6544F1BF203; Wed, 21 Aug 2024 07:41:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1724226114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cNVE1Euex1vHgd16nkcpKWq4uCJnI5txc/wed22g5ng=; b=ptK8mW9UZGOaggQGmNwz0GVW3ar1qMYjrhdzLxxeT0cZmtOUj+Yfann9zwjzSeYDpICP4a wkqW6yljlgDLZcm+YmfuYK8oFEa/uWDIdgPkrqJw1CBCbdJN5h/y+FWiy7YM1wBv+6/5kJ qPtCIUCjzaZI760eRAQHhH5qJqcR6DHTcWSuMvAvWd3rYETUkR3izusP5EHYmW9HyZkNAM MT3AoU9azucVdMJA9a7ZqtFl0WTW2ruP0EiftemmT7B3syAOpDpaCTsDkaWPejC0Y+fVQc u35aozbT8wXo8FJqb8E1oPgteuMyxcjIM+TD702CPRB9aivYSHNMPr1MZZO3eQ== Date: Wed, 21 Aug 2024 09:41:50 +0200 From: Miquel Raynal To: Conor Dooley Cc: Thomas Bonnefille , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen Wang , Inochi Amaoto , Paul Walmsley , Palmer Dabbelt , Albert Ou , Thomas Petazzoni , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v4 1/3] dt-bindings: iio: adc: sophgo,cv18xx-saradc.yaml: Add Sophgo CV18XX SARADC binding Message-ID: <20240821094150.5787905b@xps-13> In-Reply-To: <20240820-borough-latch-17d785301aef@spud> References: <20240812-sg2002-adc-v4-0-599bdb67592f@bootlin.com> <20240812-sg2002-adc-v4-1-599bdb67592f@bootlin.com> <20240812-unwary-mongrel-9f6758bf624c@spud> <89aabfbe-79bf-4da7-be44-b6cbd92b72a9@bootlin.com> <20240820-borough-latch-17d785301aef@spud> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240821_004159_024108_29557192 X-CRM114-Status: GOOD ( 22.16 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org SGVsbG8sCgo+ID4gPiA+ICsgICAgICBSZXByZXNlbnRzIHRoZSBjaGFubmVscyBvZiB0aGUgQURD Lgo+ID4gPiA+ICsKPiA+ID4gPiArICAgIHByb3BlcnRpZXM6Cj4gPiA+ID4gKyAgICAgIHJlZzoK PiA+ID4gPiArICAgICAgICBkZXNjcmlwdGlvbjogfAo+ID4gPiA+ICsgICAgICAgICAgVGhlIGNo YW5uZWwgbnVtYmVyLiBJdCBjYW4gaGF2ZSB1cCB0byAzIGNoYW5uZWxzIG51bWJlcmVkIGZyb20g MCB0byAyLgo+ID4gPiA+ICsgICAgICAgIGl0ZW1zOgo+ID4gPiA+ICsgICAgICAgICAgLSBtaW5p bXVtOiAwCj4gPiA+ID4gKyAgICAgICAgICAgIG1heGltdW06IDIgIAo+ID4gPiAKPiA+ID4gSXMg dGhpcyBzdWZmaWNpZW50IHRvIGxpbWl0IHRoZSBudW1iZXIgb2YgY2hhbm5lbHMgdG8gMz8gQXJl bid0IHlvdSByZWx5aW5nCj4gPiA+IG9uIHRoZSB1bmlxdWUgdW5pdCBhZGRyZXNzZXMgd2Fybmlu ZyBpbiBkdGMgdG8gbGltaXQgaXQsIHJhdGhlciB0aGFuCj4gPiA+IGFjdHVhbGx5IGxpbWl0aW5n IHdpdGggbWluL21heEl0ZW1zPwo+ID4gPiAgIAo+ID4gSXQgc2VlbXMgbGlrZSBJIGNhbid0IHVz ZSBtaW4vbWF4SXRlbXMgb24gdGhpcyBwcm9wZXJ0eS4gSSB0aGluayB0aGF0IGl0IGlzCj4gPiB1 c2luZyBzaXplLWNlbGxzICsgYWRkcmVzcy1jZWxscyB0byBkZWR1Y2UgdGhhdCB0aGUgbnVtYmVy IG9mIGl0ZW1zIHNob3VsZAo+ID4gYmUgZXF1YWwgdG8gMS4gIAoKTG9va2luZyBhdCBkdC1zY2hl bWEsIEkgY291bGRuJ3QgcGVyc29uYWxseSB1bmRlcnN0YW5kIGZyb20gd2hlcmUgZGlkCnRoZSBl cnJvciBtZXNzYWdlcyByZXBvcnRlZCBieSBUaG9tYXMgY2FtZSBmcm9tLiBUaGVyZSBhcmUgY2xl YXIKY29uc3RyYWludHMgb3ZlciBtaW5JdGVtcy9tYXhJdGVtcyByZWdhcmRpbmcgdGhlIHVzZSBv ZiB7I2FkZHJlc3MtY2VsbHMsCiNzaXplei1jZWxsc30gYmVpbmcgezEsIDF9LCB7MiwgMn0gYW5k IHsyLCAxfSAoaW4gcmVnLnlhbWwpLCBidXQgbm90aGluZwpleHBsaWNpdCByZWdhcmRpbmcgdGhl IG90aGVyIHNpdHVhdGlvbnMsIG5hbWVseSB7MSwgMH0gaW4gdGhpcyBjYXNlCndoaWNoIGVuZm9y Y2VzIG1heEl0ZW1zIHRvIDEgaXMgbm90IGNsZWFybHkgc3RhdGVkIGluIGFueSBvZiB0aGUgY29y ZQp5YW1sIGZpbGVzLiBBbnkgaWRlYSB3aGVyZSB0byBsb29rIGF0PyBBbHRob3VnaCwgSSdtIGNv bnZpbmNlZCB0aGVyZSBpcwpzb21ldGhpbmcgZGVmaW5lZCBiZWNhdXNlIHJlbmFtaW5nIHRoZSBw cm9wZXJ0eSBmcm9tICdyZWcnIHRvICdmb28nCnNpbGVuY2VzIHRoZXNlIHdhcm5pbmdzLgoKPiBJ IHRoaW5rIEkgd2FzIG1pc3Rha2VuIGluIHRhbGtpbmcgYWJvdXQgbWl4L21heCBpdGVtcyBoZXJl LiBJIGhhZCB0aGUKPiByaWdodCBpZGVhLCBidXQgbWVudGlvbmVkIGFuIGluY29ycmVjdCBzb2x1 dGlvbiAtIHNvcnJ5IGFib3V0IHRoYXQuIEkKPiB3YXNuJ3QgdGFsa2luZyBhYm91dCB0aGUgbnVt YmVyIG9mIGVsZW1lbnRzIGluIHRoZSByZWcgcHJvcGVydHksIHdoYXQgSQo+IG1lYW50IHdhcyBs aW1pdGluZyB0aGUgbnVtYmVyIG9mIGNoYW5uZWwgbm9kZXMgaW4gdGhlIGZpcnN0IHBsYWNlIC0K PiBzb21ldGhpbmcgd2hpY2ggbWluL21heEl0ZW1zIGNhbm5vdCBkby4gQXMgZXhhbXBsZXMgb2Yg dGhlIHByb2JsZW0gSSB3YXMKPiB0aGlua2luZyBvZiwgc2VlIHRoZSBiZWxvdyB0d28gZXhhbXBs ZXM6Cj4gCj4gICAgIGFkY0AzMGYwMDAwIHsKPiAgICAgICAgIGNvbXBhdGlibGUgPSAic29waGdv LGN2MTgwMGItc2FyYWRjIjsKPiAgICAgICAgIHJlZyA9IDwweDAzMGYwMDAwIDB4MTAwMD47Cj4g ICAgICAgICBjbG9ja3MgPSA8JmNsayBDTEtfU0FSQURDPjsKPiAgICAgICAgIGludGVycnVwdHMg PSA8MTAwIElSUV9UWVBFX0xFVkVMX0hJR0g+Owo+ICAgICAgICAgI2FkZHJlc3MtY2VsbHMgPSA8 MT47Cj4gICAgICAgICAjc2l6ZS1jZWxscyA9IDwwPjsKPiAKPiAgICAgICAgIGNoYW5uZWxAMCB7 Cj4gICAgICAgICAgICAgcmVnID0gPDA+Owo+ICAgICAgICAgfTsKPiAgICAgICAgIGNoYW5uZWxA MiB7Cj4gICAgICAgICAgICAgcmVnID0gPDI+Owo+ICAgICAgICAgfTsKPiAgICAgICAgIGNoYW5u ZWxAMjIgewo+ICAgICAgICAgICAgIHJlZyA9IDwyPjsKPiAgICAgICAgIH07Cj4gICAgIH07Cj4g Cj4gICAgIGFkY0AzMGYwMDAwIHsKPiAgICAgICAgIGNvbXBhdGlibGUgPSAic29waGdvLGN2MTgw MGItc2FyYWRjIjsKPiAgICAgICAgIHJlZyA9IDwweDAzMGYwMDAwIDB4MTAwMD47Cj4gICAgICAg ICBjbG9ja3MgPSA8JmNsayBDTEtfU0FSQURDPjsKPiAgICAgICAgIGludGVycnVwdHMgPSA8MTAw IElSUV9UWVBFX0xFVkVMX0hJR0g+Owo+ICAgICAgICAgI2FkZHJlc3MtY2VsbHMgPSA8MT47Cj4g ICAgICAgICAjc2l6ZS1jZWxscyA9IDwwPjsKPiAKPiAgICAgICAgIGNoYW5uZWxAMCB7Cj4gICAg ICAgICAgICAgcmVnID0gPDA+Owo+ICAgICAgICAgfTsKPiAgICAgICAgIGNoYW5uZWxAMiB7Cj4g ICAgICAgICAgICAgcmVnID0gPDI+Owo+ICAgICAgICAgfTsKPiAgICAgICAgIGNoYW5uZWxAMjIg ewo+ICAgICAgICAgICAgIHJlZyA9IDwyPjsKPiAgICAgICAgIH07Cj4gICAgIH07Cj4gCj4gVGhl IHNvbHV0aW9uIGlzIHNpbXBsZSwgcmVtb3ZlIHRoZSArIGZyb20gdGhlIHJlZ2V4LiBTb3JyeSBm b3Igc2VuZGluZwo+IHlvdSBvbiB0aGUgd3JvbmcgdHJhY2sgVGhvbWFzLgoKQWghIFRoYW5rcyBD b25vciBmb3IgdGhlIGRldGFpbHMsIG5vdyBpdCBtYWtlcyBmdWxsIHNlbnNlIDotKSBCVFcgVGhv bWFzCnRoZSByZWdleCBpcwoKCV5jaGFubmVsQFswLTNdKyQKCmFuZCBJIGd1ZXNzIGl0IHNob3Vs ZCBpbnN0ZWFkIGJlCgoJXmNoYW5uZWxAWzAtMl0kCiAgICAgICAgICAgICAgICAgICAgXgoKaW4g b3JkZXIgdG8gZnVsbHkgbWF0Y2ggdGhlIHJlYWwgaW5kZXhpbmcgY29uc3RyYWludHMgeW91J3Jl IGVuZm9yY2luZwp3aXRoIG1pbmltdW0vbWF4aW11bS4KClRoYW5rcywKTWlxdcOobAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFp bGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo=