Re: [PATCH 06/11] clk: rp1: Add support for clocks provided by RP1

[kernel test robot <lkp@intel.com>]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <a378cc652b7e92b4022141dd2f20711e1771eb72.1724159867.git.andrea.porta@suse.com>
References: <a378cc652b7e92b4022141dd2f20711e1771eb72.1724159867.git.andrea.porta@suse.com>
TO: Andrea della Porta <andrea.porta@suse.com>
TO: Andrea della Porta <andrea.porta@suse.com>
TO: Michael Turquette <mturquette@baylibre.com>
TO: Stephen Boyd <sboyd@kernel.org>
TO: Rob Herring <robh@kernel.org>
TO: Krzysztof Kozlowski <krzk@kernel.org>
TO: Conor Dooley <conor+dt@kernel.org>
TO: Florian Fainelli <florian.fainelli@broadcom.com>
TO: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>
TO: Linus Walleij <linus.walleij@linaro.org>
TO: Catalin Marinas <catalin.marinas@arm.com>
TO: Will Deacon <will@kernel.org>
TO: Derek Kiernan <derek.kiernan@amd.com>
TO: Dragan Cvetic <dragan.cvetic@amd.com>
TO: Arnd Bergmann <arnd@arndb.de>
TO: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
TO: Nicolas Ferre <nicolas.ferre@microchip.com>
TO: Claudiu Beznea <claudiu.beznea@tuxon.dev>
TO: "David S. Miller" <davem@davemloft.net>
CC: netdev@vger.kernel.org
TO: Eric Dumazet <edumazet@google.com>
TO: Jakub Kicinski <kuba@kernel.org>
TO: Paolo Abeni <pabeni@redhat.com>
TO: Saravana Kannan <saravanak@google.com>
TO: Bjorn Helgaas <helgaas@kernel.org>
TO: linux-clk@vger.kernel.org
TO: devicetree@vger.kernel.org
TO: linux-rpi-kernel@lists.infradead.org
TO: linux-arm-kernel@lists.infradead.org
TO: linux-kernel@vger.kernel.org
TO: linux-gpio@vger.kernel.org

Hi Andrea,

kernel test robot noticed the following build warnings:

[auto build test WARNING on clk/clk-next]
[also build test WARNING on robh/for-next char-misc/char-misc-testing char-misc/char-misc-next char-misc/char-misc-linus linus/master v6.11-rc4 next-20240821]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Andrea-della-Porta/dt-bindings-clock-Add-RaspberryPi-RP1-clock-bindings/20240821-023901
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
patch link:    https://lore.kernel.org/r/a378cc652b7e92b4022141dd2f20711e1771eb72.1724159867.git.andrea.porta%40suse.com
patch subject: [PATCH 06/11] clk: rp1: Add support for clocks provided by RP1
:::::: branch date: 31 hours ago
:::::: commit date: 31 hours ago
config: x86_64-randconfig-102-20240822 (https://download.01.org/0day-ci/archive/20240822/202408220911.Fevyd0GY-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202408220911.Fevyd0GY-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/clk/clk-rp1.c:1088:3-9: preceding lock on line 1082

vim +1088 drivers/clk/clk-rp1.c

9b0943ce9656da Andrea della Porta 2024-08-20  1074  
9b0943ce9656da Andrea della Porta 2024-08-20  1075  static int rp1_clock_set_parent(struct clk_hw *hw, u8 index)
9b0943ce9656da Andrea della Porta 2024-08-20  1076  {
9b0943ce9656da Andrea della Porta 2024-08-20  1077  	struct rp1_clock *clock = container_of(hw, struct rp1_clock, hw);
9b0943ce9656da Andrea della Porta 2024-08-20  1078  	struct rp1_clockman *clockman = clock->clockman;
9b0943ce9656da Andrea della Porta 2024-08-20  1079  	const struct rp1_clock_data *data = clock->data;
9b0943ce9656da Andrea della Porta 2024-08-20  1080  	u32 ctrl, sel;
9b0943ce9656da Andrea della Porta 2024-08-20  1081  
9b0943ce9656da Andrea della Porta 2024-08-20 @1082  	spin_lock(&clockman->regs_lock);
9b0943ce9656da Andrea della Porta 2024-08-20  1083  	ctrl = clockman_read(clockman, data->ctrl_reg);
9b0943ce9656da Andrea della Porta 2024-08-20  1084  
9b0943ce9656da Andrea della Porta 2024-08-20  1085  	if (index >= data->num_std_parents) {
9b0943ce9656da Andrea della Porta 2024-08-20  1086  		/* This is an aux source request */
9b0943ce9656da Andrea della Porta 2024-08-20  1087  		if (index >= data->num_std_parents + data->num_aux_parents)
9b0943ce9656da Andrea della Porta 2024-08-20 @1088  			return -EINVAL;
9b0943ce9656da Andrea della Porta 2024-08-20  1089  
9b0943ce9656da Andrea della Porta 2024-08-20  1090  		/* Select parent from aux list */
9b0943ce9656da Andrea della Porta 2024-08-20  1091  		ctrl = set_register_field(ctrl, index - data->num_std_parents,
9b0943ce9656da Andrea della Porta 2024-08-20  1092  					  CLK_CTRL_AUXSRC_MASK,
9b0943ce9656da Andrea della Porta 2024-08-20  1093  					  CLK_CTRL_AUXSRC_SHIFT);
9b0943ce9656da Andrea della Porta 2024-08-20  1094  		/* Set src to aux list */
9b0943ce9656da Andrea della Porta 2024-08-20  1095  		ctrl = set_register_field(ctrl, AUX_SEL, data->clk_src_mask,
9b0943ce9656da Andrea della Porta 2024-08-20  1096  					  CLK_CTRL_SRC_SHIFT);
9b0943ce9656da Andrea della Porta 2024-08-20  1097  	} else {
9b0943ce9656da Andrea della Porta 2024-08-20  1098  		ctrl = set_register_field(ctrl, index, data->clk_src_mask,
9b0943ce9656da Andrea della Porta 2024-08-20  1099  					  CLK_CTRL_SRC_SHIFT);
9b0943ce9656da Andrea della Porta 2024-08-20  1100  	}
9b0943ce9656da Andrea della Porta 2024-08-20  1101  
9b0943ce9656da Andrea della Porta 2024-08-20  1102  	clockman_write(clockman, data->ctrl_reg, ctrl);
9b0943ce9656da Andrea della Porta 2024-08-20  1103  	spin_unlock(&clockman->regs_lock);
9b0943ce9656da Andrea della Porta 2024-08-20  1104  
9b0943ce9656da Andrea della Porta 2024-08-20  1105  	sel = rp1_clock_get_parent(hw);
9b0943ce9656da Andrea della Porta 2024-08-20  1106  	WARN(sel != index, "(%s): Parent index req %u returned back %u\n",
9b0943ce9656da Andrea della Porta 2024-08-20  1107  	     data->name, index, sel);
9b0943ce9656da Andrea della Porta 2024-08-20  1108  
9b0943ce9656da Andrea della Porta 2024-08-20  1109  	return 0;
9b0943ce9656da Andrea della Porta 2024-08-20  1110  }
9b0943ce9656da Andrea della Porta 2024-08-20  1111  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki