Re: [Intel-wired-lan] [PATCH iwl-next v10 14/14] iavf: add support for Rx timestamps to hotpath

[kernel test robot <lkp@intel.com>]

Hi Wojciech,

kernel test robot noticed the following build errors:

[auto build test ERROR on tnguy-next-queue/dev-queue]

url:    https://github.com/intel-lab-lkp/linux/commits/Wojciech-Drewek/virtchnl-add-support-for-enabling-PTP-on-iAVF/20240821-202156
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue
patch link:    https://lore.kernel.org/r/20240821121539.374343-15-wojciech.drewek%40intel.com
patch subject: [Intel-wired-lan] [PATCH iwl-next v10 14/14] iavf: add support for Rx timestamps to hotpath
config: i386-buildonly-randconfig-002-20240822 (https://download.01.org/0day-ci/archive/20240822/202408222123.LEHTAhtq-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240822/202408222123.LEHTAhtq-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408222123.LEHTAhtq-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: drivers/net/ethernet/intel/iavf/iavf_main.o: in function `iavf_hwstamp_set':
   drivers/net/ethernet/intel/iavf/iavf_main.c:5095: undefined reference to `iavf_ptp_set_ts_config'
   ld: drivers/net/ethernet/intel/iavf/iavf_main.o: in function `iavf_select_rx_desc_format':
>> drivers/net/ethernet/intel/iavf/iavf_main.c:734: undefined reference to `iavf_ptp_cap_supported'
   ld: drivers/net/ethernet/intel/iavf/iavf_main.o: in function `iavf_remove':
   drivers/net/ethernet/intel/iavf/iavf_main.c:5517: undefined reference to `iavf_ptp_release'
   ld: drivers/net/ethernet/intel/iavf/iavf_main.o: in function `iavf_init_config_adapter':
   drivers/net/ethernet/intel/iavf/iavf_main.c:2851: undefined reference to `iavf_ptp_init'
   ld: drivers/net/ethernet/intel/iavf/iavf_virtchnl.o: in function `iavf_configure_queues':
   drivers/net/ethernet/intel/iavf/iavf_virtchnl.c:409: undefined reference to `iavf_ptp_cap_supported'
   ld: drivers/net/ethernet/intel/iavf/iavf_virtchnl.o: in function `iavf_virtchnl_completion':
   drivers/net/ethernet/intel/iavf/iavf_virtchnl.c:2595: undefined reference to `iavf_ptp_process_caps'
   ld: drivers/net/ethernet/intel/iavf/iavf_txrx.o: in function `iavf_flex_rx_tstamp':
>> drivers/net/ethernet/intel/iavf/iavf_txrx.c:1124: undefined reference to `iavf_ptp_extend_32b_timestamp'
   ld: net/core/net-sysfs.o: in function `netdev_queue_update_kobjects':
   net/core/net-sysfs.c:1852: undefined reference to `dql_group'
   ld: net/core/net-sysfs.o: in function `netdev_queue_add_kobject':
   net/core/net-sysfs.c:1792: undefined reference to `dql_group'


vim +734 drivers/net/ethernet/intel/iavf/iavf_main.c

   712	
   713	/**
   714	 * iavf_select_rx_desc_format - Select Rx descriptor format
   715	 * @adapter: adapter private structure
   716	 *
   717	 * Select what Rx descriptor format based on availability and enabled
   718	 * features.
   719	 *
   720	 * Return: the desired RXDID to select for a given Rx queue, as defined by
   721	 *         enum virtchnl_rxdid_format.
   722	 */
   723	static u8 iavf_select_rx_desc_format(const struct iavf_adapter *adapter)
   724	{
   725		u64 rxdids = adapter->supp_rxdids;
   726	
   727		/* If we did not negotiate VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC, we must
   728		 * stick with the default value of the legacy 32 byte format.
   729		 */
   730		if (!IAVF_RXDID_ALLOWED(adapter))
   731			return VIRTCHNL_RXDID_1_32B_BASE;
   732	
   733		/* Rx timestamping requires the use of flexible NIC descriptors */
 > 734		if (iavf_ptp_cap_supported(adapter, VIRTCHNL_1588_PTP_CAP_RX_TSTAMP)) {
   735			if (rxdids & BIT(VIRTCHNL_RXDID_2_FLEX_SQ_NIC))
   736				return VIRTCHNL_RXDID_2_FLEX_SQ_NIC;
   737	
   738			pci_warn(adapter->pdev,
   739				 "Unable to negotiate flexible descriptor format\n");
   740		}
   741	
   742		/* Warn if the PF does not list support for the default legacy
   743		 * descriptor format. This shouldn't happen, as this is the format
   744		 * used if VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC is not supported. It is
   745		 * likely caused by a bug in the PF implementation failing to indicate
   746		 * support for the format.
   747		 */
   748		if (!(rxdids & VIRTCHNL_RXDID_1_32B_BASE_M))
   749			pci_warn(adapter->pdev, "PF does not list support for default Rx descriptor format\n");
   750	
   751		return VIRTCHNL_RXDID_1_32B_BASE;
   752	}
   753	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki