From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Esther Shimanovich <eshimanovich@chromium.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Rajat Jain <rajatja@google.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
iommu@lists.linux.dev, Lukas Wunner <lukas@wunner.de>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] PCI: Detect and trust built-in Thunderbolt chips
Date: Fri, 23 Aug 2024 08:01:20 +0300 [thread overview]
Message-ID: <20240823050120.GJ1532424@black.fi.intel.com> (raw)
In-Reply-To: <54feb448-b8b9-49ca-bf29-02b9884c048c@amd.com>
Hi,
On Thu, Aug 22, 2024 at 10:56:44AM -0500, Mario Limonciello wrote:
> > > Here's the snippet from the kernel log with the patch in place. You can see
> > > it flagged 00:02.0 as untrusted and removable, but it definitely isn't.
> >
> > Is it marked as ExternalFacingPort in the ACPI tables?
>
> No; it doesn't have an ACPI companion device.
Hm, how can it pass this then?
static bool pcie_is_tunneled(struct pci_dev *pdev)
{
...
/* Internal PCIe devices are not tunneled. */
if (!root->external_facing)
return false;
...
Would you mind adding some debug statements there so we can see
(hopefully) what goes wrong?
The intention is that pcie_switch_directly_under() is only called on
Intel pre-USB4 discrete controllers (well and Maple Ridge as that's
still using the Connection Manager firmware).
next prev parent reply other threads:[~2024-08-23 5:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 19:07 [PATCH v3] PCI: Detect and trust built-in Thunderbolt chips Esther Shimanovich
2024-08-20 16:13 ` Ilpo Järvinen
2024-08-22 15:29 ` Mario Limonciello
2024-08-22 15:53 ` Mika Westerberg
2024-08-22 15:56 ` Mario Limonciello
2024-08-23 5:01 ` Mika Westerberg [this message]
2024-08-23 15:36 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240823050120.GJ1532424@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=eshimanovich@chromium.org \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mario.limonciello@amd.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rajatja@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.