From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Santosh Shilimkar <ssantosh@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Roger Quadros <rogerq@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Vladimir Zapolskiy <vz@mleia.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Michal Simek <michal.simek@amd.com>,
<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/7] memory: emif: simplify locking with guard()
Date: Fri, 23 Aug 2024 12:40:33 +0100 [thread overview]
Message-ID: <20240823124033.00007f76@Huawei.com> (raw)
In-Reply-To: <20240823-b4-cleanup-h-guard-v1-2-01668915bd55@linaro.org>
On Fri, 23 Aug 2024 12:15:57 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> Simplify error handling (less gotos) over locks with guard().
>
> The driver used file-scope variable 'irq_state' for storing IRQ state
> with spin_lock_irqsave, so move it into respective local scopes. This
> should be equivalent, but more readable (less global variables).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
LGTM. File scoped irq_state is certainly unusual...
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huwei.com>
next prev parent reply other threads:[~2024-08-23 11:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 10:15 [PATCH 0/7] memory: simplify with devm() and guard() Krzysztof Kozlowski
2024-08-23 10:15 ` [PATCH 1/7] memory: emif: drop unused 'irq_state' member Krzysztof Kozlowski
2024-08-23 10:15 ` [PATCH 2/7] memory: emif: simplify locking with guard() Krzysztof Kozlowski
2024-08-23 11:40 ` Jonathan Cameron [this message]
2024-08-23 10:15 ` [PATCH 3/7] memory: omap-gpmc: " Krzysztof Kozlowski
2024-08-23 11:42 ` Jonathan Cameron
2024-08-23 10:15 ` [PATCH 4/7] memory: pl172: simplify with dev_err_probe() Krzysztof Kozlowski
2024-08-23 11:46 ` Jonathan Cameron
2024-08-23 12:22 ` Vladimir Zapolskiy
2024-08-23 10:16 ` [PATCH 5/7] memory: pl172: simplify with devm_clk_get_enabled() Krzysztof Kozlowski
2024-08-23 11:51 ` Jonathan Cameron
2024-08-23 12:22 ` Vladimir Zapolskiy
2024-08-23 10:16 ` [PATCH 6/7] memory: pl353-smc: simplify with dev_err_probe() Krzysztof Kozlowski
2024-08-23 11:22 ` Miquel Raynal
2024-08-23 11:53 ` Jonathan Cameron
2024-08-23 10:16 ` [PATCH 7/7] memory: pl353-smc: simplify with devm_clk_get_enabled() Krzysztof Kozlowski
2024-08-23 11:23 ` Miquel Raynal
2024-08-23 11:56 ` Jonathan Cameron
2024-08-25 8:13 ` Krzysztof Kozlowski
2024-08-25 12:22 ` [PATCH 0/7] memory: simplify with devm() and guard() Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240823124033.00007f76@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=miquel.raynal@bootlin.com \
--cc=rogerq@kernel.org \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.