From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BC3A189536; Fri, 23 Aug 2024 15:37:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724427481; cv=none; b=CezNGI6E4OoNLncZeKSXYzog1WD3URp12nGFrkXQKw6cpBzlnxsuq4t6firmBmzS57xYofY0KBC5/0gvA6y2P31vPFZNQckghAXEC9SvxLn6J3HumeSTmBvAzwJ+cj1OQkyWi9buD/NQUWDPZGrCCTuLxjv/+qF4Qc4FAXrIVX8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724427481; c=relaxed/simple; bh=zCxIRWkih4tuPLzhcTwAD0rHAXZgw44YpE8z23P2up4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ryqOi1WcRX7Ofa2Tkkgl5Y1CAPPaE/hmEJsTs3xRaRGktCFbFbm256UfQH5HTe6kSEU8I0/+u/g8zxbQ9OFnXcjBjDLXwH5cIK5D3su4sBeOLwuAj/NuYIBg9H0GpZhE5xxvsgzi1yVwrD2LLbW2F9XH4izHFZyTfT+t+QqO+vs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=EQgdhHc1; arc=none smtp.client-ip=217.70.183.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="EQgdhHc1" Received: by mail.gandi.net (Postfix) with ESMTPSA id DCDC41BF206; Fri, 23 Aug 2024 15:37:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1724427477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7CutgodhxN+FJr5V+VHWsJBhY68LFF7RKhgiCY4alWI=; b=EQgdhHc1vU0jHveAWULFKVBKA5K/Reu7E11e/ThNq9x2gK+seD0B13sWiulonMlwdOssZ+ k+eOdW0o2tv4Ud7+Sc+JOMrfETHvLbvlgyy+kMY6NXxlMbsUmLZ7/FAN5WXqj27n4bSlr+ dmDpxLQ/Z+1AQ01pr9Z1lBOL3BCycoIwydon6a7UJIbtuAqynLhzcVgS7Tyw1JXQgEmX0x VOnCrmUGt8M8ZePqnH/ue6a4gvzyEDN1u3bA6Elhg+jRCgsbvMd5Mx/JhrjqIxq4e6ckw+ detDzZoFkx9y82FATvoOoDjp178jqdsLKA7rVAVuQiUuWcQl3YXaclc2dwkXfg== Date: Fri, 23 Aug 2024 17:37:48 +0200 From: Miquel Raynal To: Marco Felsch Cc: Maxime Ripard , Pratyush Yadav , Tudor Ambarus , Richard Weinberger , Vignesh Raghavendra , Arnd Bergmann , Greg Kroah-Hartman , Bartosz Golaszewski , Russell King , Joel Stanley , Andrew Jeffery , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Vladimir Zapolskiy , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Tony Lindgren , Geert Uytterhoeven , Magnus Damm , Dinh Nguyen , Thierry Reding , Jonathan Hunter , Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Naveen N. Rao" , Thomas Bogendoerfer , Huacai Chen , WANG Xuerui , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, imx@lists.linux.dev, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org, openbmc@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org, linux-mips@vger.kernel.org, loongarch@lists.linux.dev, Michael Walle Subject: Re: [PATCH 4/9] mtd: devices: add AT24 eeprom support Message-ID: <20240823173748.2b3a364a@xps-13> In-Reply-To: <20240718091753.apwsrvmekn2vvo4k@pengutronix.de> References: <07b701a9-7b52-45b7-8dba-1c25d77cbf15@linaro.org> <20240702-congenial-vigilant-boar-aeae44@houat> <20240702-mighty-brilliant-eel-b0d9fa@houat> <20240708084440.70186564@xps-13> <20240709092214.omr7ccphdzdk7z7j@pengutronix.de> <20240709114302.3c604ef3@xps-13> <20240709103841.7x7n4hdtqrunyoc3@pengutronix.de> <20240717101948.2e99f472@xps-13> <20240718091753.apwsrvmekn2vvo4k@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Hi Marco, m.felsch@pengutronix.de wrote on Thu, 18 Jul 2024 11:17:53 +0200: > Hi Miquel, >=20 > On 24-07-17, Miquel Raynal wrote: > > Hi Marco, > > =20 > > > > > > Overall I think the idea of getting rid of these misc/ drivers = is goes > > > > > > into the right direction, but registering directly into NVMEM m= akes > > > > > > more sense IMO. =20 > > > > >=20 > > > > > So you propose to have two places for the partition handling (one= for > > > > > MTD and one for NVMEM) instead of one and moving the code into NV= MEM > > > > > directly? =20 > > > >=20 > > > > Why two places for the partitions handling? Just one, in NVMEM. Als= o =20 > > >=20 > > > Without checking the details I think that converting the MTD > > > partitioning code into NVMEM partitioning code is a bigger task. As y= ou > > > said below there are many legacy code paths you need to consider so t= hey > > > still work afterwards as well. > > > =20 > > > > usually EEPROMs don't require very advanced partitioning schemes, > > > > unlike flashes (which are the most common MTD devices today). =20 > > >=20 > > > As said in my cover letter EEPROMs can become quite large and MTD > > > supports partitioning storage devices which is very handy for large > > > EEPROMs as well. =20 > >=20 > > Did you had a look at nvmem-layouts ? In particular the fixed-layout. = =20 >=20 > Yes I had a look at nvmem-layouts and we use them within a > mtd-partition. Using them instead of a mtd-partition is not sufficient > since they: > 1) don't support user-space write (I send a patch for it but it doesn't > seem to be accepted soon). Yes, this needed improvements maybe but was not refused either. > 2) If write would be supported the user-space need to write the > complete cell e.g. no partial writes. Maybe that can also be brought to nvmem. Again, nvmem was introduced for handling EEPROMs in the first place. Anyway, if other people in Cc: want to share some thoughts, they are also welcomed, I don't want to block this series for bad reasons. I'm also adding Michael Walle in Cc: who might have an opinion on that. Link: https://lore.kernel.org/linux-mtd/20240701-b4-v6-10-topic-usbc-tcpci-= v1-4-3fd5f4a193cc@pengutronix.de/ Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Date: Fri, 23 Aug 2024 17:37:48 +0200 Subject: [PATCH 4/9] mtd: devices: add AT24 eeprom support In-Reply-To: <20240718091753.apwsrvmekn2vvo4k@pengutronix.de> References: <07b701a9-7b52-45b7-8dba-1c25d77cbf15@linaro.org> <20240702-congenial-vigilant-boar-aeae44@houat> <20240702-mighty-brilliant-eel-b0d9fa@houat> <20240708084440.70186564@xps-13> <20240709092214.omr7ccphdzdk7z7j@pengutronix.de> <20240709114302.3c604ef3@xps-13> <20240709103841.7x7n4hdtqrunyoc3@pengutronix.de> <20240717101948.2e99f472@xps-13> <20240718091753.apwsrvmekn2vvo4k@pengutronix.de> Message-ID: <20240823173748.2b3a364a@xps-13> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Marco, m.felsch at pengutronix.de wrote on Thu, 18 Jul 2024 11:17:53 +0200: > Hi Miquel, > > On 24-07-17, Miquel Raynal wrote: > > Hi Marco, > > > > > > > > Overall I think the idea of getting rid of these misc/ drivers is goes > > > > > > into the right direction, but registering directly into NVMEM makes > > > > > > more sense IMO. > > > > > > > > > > So you propose to have two places for the partition handling (one for > > > > > MTD and one for NVMEM) instead of one and moving the code into NVMEM > > > > > directly? > > > > > > > > Why two places for the partitions handling? Just one, in NVMEM. Also > > > > > > Without checking the details I think that converting the MTD > > > partitioning code into NVMEM partitioning code is a bigger task. As you > > > said below there are many legacy code paths you need to consider so they > > > still work afterwards as well. > > > > > > > usually EEPROMs don't require very advanced partitioning schemes, > > > > unlike flashes (which are the most common MTD devices today). > > > > > > As said in my cover letter EEPROMs can become quite large and MTD > > > supports partitioning storage devices which is very handy for large > > > EEPROMs as well. > > > > Did you had a look at nvmem-layouts ? In particular the fixed-layout. > > Yes I had a look at nvmem-layouts and we use them within a > mtd-partition. Using them instead of a mtd-partition is not sufficient > since they: > 1) don't support user-space write (I send a patch for it but it doesn't > seem to be accepted soon). Yes, this needed improvements maybe but was not refused either. > 2) If write would be supported the user-space need to write the > complete cell e.g. no partial writes. Maybe that can also be brought to nvmem. Again, nvmem was introduced for handling EEPROMs in the first place. Anyway, if other people in Cc: want to share some thoughts, they are also welcomed, I don't want to block this series for bad reasons. I'm also adding Michael Walle in Cc: who might have an opinion on that. Link: https://lore.kernel.org/linux-mtd/20240701-b4-v6-10-topic-usbc-tcpci-v1-4-3fd5f4a193cc at pengutronix.de/ Thanks, Miqu?l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7831AC54731 for ; Fri, 23 Aug 2024 15:40:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w9wpBDm3hSYQbDKsxgK8rwszVgSHjYQsxEjtF68nbgE=; b=csx3f3vVhtEjd+ skwC/UzTVre7Q3CRSuHvm9MWQ5Ch1PDhsHi5Jw02YIDydpUqpHK+8GTYOmT7ruMQVpWLGcVutUK2A jJVi8GklGNkUzon00tLrgQpM9zoSXGkbyI8KuQmmRceeLvrpzyH2GF8ztk/4Q5qYY9s3He9pHDxpe 4hxXvGGZCfGve1c1O5mrt3BvfVmgCquo+UA8q11XDVfG/0XZGxF4hgV0SXYSxX/wydIwjMtIqjISi JzplSuZ+vbmcBrhKt27xei/hE16ZtHwTfHOIfvTem2ELsvJxazCJ3/pStjgqaoEeljvC6HjOIv+zt pc+LSRDMpJoWcleR1toQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1shWP8-0000000HLV3-13oZ; Fri, 23 Aug 2024 15:40:46 +0000 Received: from relay8-d.mail.gandi.net ([2001:4b98:dc4:8::228]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shWMS-0000000HKnB-1bOJ; Fri, 23 Aug 2024 15:38:03 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id DCDC41BF206; Fri, 23 Aug 2024 15:37:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1724427477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7CutgodhxN+FJr5V+VHWsJBhY68LFF7RKhgiCY4alWI=; b=EQgdhHc1vU0jHveAWULFKVBKA5K/Reu7E11e/ThNq9x2gK+seD0B13sWiulonMlwdOssZ+ k+eOdW0o2tv4Ud7+Sc+JOMrfETHvLbvlgyy+kMY6NXxlMbsUmLZ7/FAN5WXqj27n4bSlr+ dmDpxLQ/Z+1AQ01pr9Z1lBOL3BCycoIwydon6a7UJIbtuAqynLhzcVgS7Tyw1JXQgEmX0x VOnCrmUGt8M8ZePqnH/ue6a4gvzyEDN1u3bA6Elhg+jRCgsbvMd5Mx/JhrjqIxq4e6ckw+ detDzZoFkx9y82FATvoOoDjp178jqdsLKA7rVAVuQiUuWcQl3YXaclc2dwkXfg== Date: Fri, 23 Aug 2024 17:37:48 +0200 From: Miquel Raynal To: Marco Felsch Cc: Maxime Ripard , Pratyush Yadav , Tudor Ambarus , Richard Weinberger , Vignesh Raghavendra , Arnd Bergmann , Greg Kroah-Hartman , Bartosz Golaszewski , Russell King , Joel Stanley , Andrew Jeffery , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Vladimir Zapolskiy , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Tony Lindgren , Geert Uytterhoeven , Magnus Damm , Dinh Nguyen , Thierry Reding , Jonathan Hunter , Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Naveen N. Rao" , Thomas Bogendoerfer , Huacai Chen , WANG Xuerui , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, imx@lists.linux.dev, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org, openbmc@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org, linux-mips@vger.kernel.org, loongarch@lists.linux.dev, Michael Walle Subject: Re: [PATCH 4/9] mtd: devices: add AT24 eeprom support Message-ID: <20240823173748.2b3a364a@xps-13> In-Reply-To: <20240718091753.apwsrvmekn2vvo4k@pengutronix.de> References: <07b701a9-7b52-45b7-8dba-1c25d77cbf15@linaro.org> <20240702-congenial-vigilant-boar-aeae44@houat> <20240702-mighty-brilliant-eel-b0d9fa@houat> <20240708084440.70186564@xps-13> <20240709092214.omr7ccphdzdk7z7j@pengutronix.de> <20240709114302.3c604ef3@xps-13> <20240709103841.7x7n4hdtqrunyoc3@pengutronix.de> <20240717101948.2e99f472@xps-13> <20240718091753.apwsrvmekn2vvo4k@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240823_083801_054856_9F38E590 X-CRM114-Status: GOOD ( 24.93 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgTWFyY28sCgptLmZlbHNjaEBwZW5ndXRyb25peC5kZSB3cm90ZSBvbiBUaHUsIDE4IEp1bCAy MDI0IDExOjE3OjUzICswMjAwOgoKPiBIaSBNaXF1ZWwsCj4gCj4gT24gMjQtMDctMTcsIE1pcXVl bCBSYXluYWwgd3JvdGU6Cj4gPiBIaSBNYXJjbywKPiA+ICAgCj4gPiA+ID4gPiA+IE92ZXJhbGwg SSB0aGluayB0aGUgaWRlYSBvZiBnZXR0aW5nIHJpZCBvZiB0aGVzZSBtaXNjLyBkcml2ZXJzIGlz IGdvZXMKPiA+ID4gPiA+ID4gaW50byB0aGUgcmlnaHQgZGlyZWN0aW9uLCBidXQgcmVnaXN0ZXJp bmcgZGlyZWN0bHkgaW50byBOVk1FTSBtYWtlcwo+ID4gPiA+ID4gPiBtb3JlIHNlbnNlIElNTy4g ICAgICAKPiA+ID4gPiA+IAo+ID4gPiA+ID4gU28geW91IHByb3Bvc2UgdG8gaGF2ZSB0d28gcGxh Y2VzIGZvciB0aGUgcGFydGl0aW9uIGhhbmRsaW5nIChvbmUgZm9yCj4gPiA+ID4gPiBNVEQgYW5k IG9uZSBmb3IgTlZNRU0pIGluc3RlYWQgb2Ygb25lIGFuZCBtb3ZpbmcgdGhlIGNvZGUgaW50byBO Vk1FTQo+ID4gPiA+ID4gZGlyZWN0bHk/ICAgIAo+ID4gPiA+IAo+ID4gPiA+IFdoeSB0d28gcGxh Y2VzIGZvciB0aGUgcGFydGl0aW9ucyBoYW5kbGluZz8gSnVzdCBvbmUsIGluIE5WTUVNLiBBbHNv ICAgIAo+ID4gPiAKPiA+ID4gV2l0aG91dCBjaGVja2luZyB0aGUgZGV0YWlscyBJIHRoaW5rIHRo YXQgY29udmVydGluZyB0aGUgTVRECj4gPiA+IHBhcnRpdGlvbmluZyBjb2RlIGludG8gTlZNRU0g cGFydGl0aW9uaW5nIGNvZGUgaXMgYSBiaWdnZXIgdGFzay4gQXMgeW91Cj4gPiA+IHNhaWQgYmVs b3cgdGhlcmUgYXJlIG1hbnkgbGVnYWN5IGNvZGUgcGF0aHMgeW91IG5lZWQgdG8gY29uc2lkZXIg c28gdGhleQo+ID4gPiBzdGlsbCB3b3JrIGFmdGVyd2FyZHMgYXMgd2VsbC4KPiA+ID4gICAKPiA+ ID4gPiB1c3VhbGx5IEVFUFJPTXMgZG9uJ3QgcmVxdWlyZSB2ZXJ5IGFkdmFuY2VkIHBhcnRpdGlv bmluZyBzY2hlbWVzLAo+ID4gPiA+IHVubGlrZSBmbGFzaGVzICh3aGljaCBhcmUgdGhlIG1vc3Qg Y29tbW9uIE1URCBkZXZpY2VzIHRvZGF5KS4gICAgCj4gPiA+IAo+ID4gPiBBcyBzYWlkIGluIG15 IGNvdmVyIGxldHRlciBFRVBST01zIGNhbiBiZWNvbWUgcXVpdGUgbGFyZ2UgYW5kIE1URAo+ID4g PiBzdXBwb3J0cyBwYXJ0aXRpb25pbmcgc3RvcmFnZSBkZXZpY2VzIHdoaWNoIGlzIHZlcnkgaGFu ZHkgZm9yIGxhcmdlCj4gPiA+IEVFUFJPTXMgYXMgd2VsbC4gIAo+ID4gCj4gPiBEaWQgeW91IGhh ZCBhIGxvb2sgYXQgbnZtZW0tbGF5b3V0cyA/IEluIHBhcnRpY3VsYXIgdGhlIGZpeGVkLWxheW91 dC4gIAo+IAo+IFllcyBJIGhhZCBhIGxvb2sgYXQgbnZtZW0tbGF5b3V0cyBhbmQgd2UgdXNlIHRo ZW0gd2l0aGluIGEKPiBtdGQtcGFydGl0aW9uLiBVc2luZyB0aGVtIGluc3RlYWQgb2YgYSBtdGQt cGFydGl0aW9uIGlzIG5vdCBzdWZmaWNpZW50Cj4gc2luY2UgdGhleToKPiAgMSkgZG9uJ3Qgc3Vw cG9ydCB1c2VyLXNwYWNlIHdyaXRlIChJIHNlbmQgYSBwYXRjaCBmb3IgaXQgYnV0IGl0IGRvZXNu J3QKPiAgICAgc2VlbSB0byBiZSBhY2NlcHRlZCBzb29uKS4KClllcywgdGhpcyBuZWVkZWQgaW1w cm92ZW1lbnRzIG1heWJlIGJ1dCB3YXMgbm90IHJlZnVzZWQgZWl0aGVyLgoKPiAgMikgSWYgd3Jp dGUgd291bGQgYmUgc3VwcG9ydGVkIHRoZSB1c2VyLXNwYWNlIG5lZWQgdG8gd3JpdGUgdGhlCj4g ICAgIGNvbXBsZXRlIGNlbGwgZS5nLiBubyBwYXJ0aWFsIHdyaXRlcy4KCk1heWJlIHRoYXQgY2Fu IGFsc28gYmUgYnJvdWdodCB0byBudm1lbS4gQWdhaW4sIG52bWVtIHdhcyBpbnRyb2R1Y2VkCmZv ciBoYW5kbGluZyBFRVBST01zIGluIHRoZSBmaXJzdCBwbGFjZS4KCkFueXdheSwgaWYgb3RoZXIg cGVvcGxlIGluIENjOiB3YW50IHRvIHNoYXJlIHNvbWUgdGhvdWdodHMsIHRoZXkgYXJlCmFsc28g d2VsY29tZWQsIEkgZG9uJ3Qgd2FudCB0byBibG9jayB0aGlzIHNlcmllcyBmb3IgYmFkIHJlYXNv bnMuIEknbQphbHNvIGFkZGluZyBNaWNoYWVsIFdhbGxlIGluIENjOiB3aG8gbWlnaHQgaGF2ZSBh biBvcGluaW9uIG9uIHRoYXQuCgpMaW5rOiBodHRwczovL2xvcmUua2VybmVsLm9yZy9saW51eC1t dGQvMjAyNDA3MDEtYjQtdjYtMTAtdG9waWMtdXNiYy10Y3BjaS12MS00LTNmZDVmNGExOTNjY0Bw ZW5ndXRyb25peC5kZS8KClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxp bmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LW10ZC8K