From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FE6418A6A9 for ; Fri, 23 Aug 2024 16:22:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724430165; cv=none; b=l523KMuEa1syGJG9gV7QeQ06MZAvVUQLILOzFQUNLOUCFuwqXfCmroUbv3+QVFAtX/btkoqmzkkiY92KMwbXubNrNd2fCORlqb9CGc+tCHVAZeq9MdUD3G9NrkzYJtVLGpUQqXhBTNBAoVGP/aHLwvbZof62s7nDAbZ1gZOVBwg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724430165; c=relaxed/simple; bh=lfUBL2AIr79LkgcCBnHySmnR5d9p6zN0glP5iosaLK4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NKOZ2CBz/SeI3ckKEx+QGrq8viiTJZ9obIN8nfue37+Nr25KJcHTbhpOLHgQGUNlDt0c++QzWNzW00lGkC4xGkv7bw4793zbsTfRUq7BSqa8A7MxfovH/EeRmOC0PEWXCC6HG2jqIUc+izjswhVIYzcrwPugYPyXtwKqFMD+4O0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=ayf+nahe; arc=none smtp.client-ip=217.70.183.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="ayf+nahe" Received: by mail.gandi.net (Postfix) with ESMTPSA id F22132000A; Fri, 23 Aug 2024 16:22:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1724430161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c6F56iukWQmBKV4FnNA9eGRhnnKZh7f5FQn4pHMuYTo=; b=ayf+nahesCes2xk0GsQMQ2Lp6XTVqom0g0ioc1dzKBHm2CpY+8aXOURfJFfbKDCiW0RJrV eOyZe4VHBpQvrE5stkxdh6dPRhUIIRe4rS6yCNDqcbvk6jyYdzSXts9crXq1UsrULd7TEb etl12fizgZ7EL5WVsLBGSKvh1loDTfofKq3wfU4RH/0o/1StE3hsSTRijFLgVeis6JG5kf fmfDaUVbE3Tu+ruIOiycqNTRiiZi2NwNn6CbJ33ejUVyh6YpJtk7/6xRRSm95hYg6Mc+wu Dz3mWkDBkbsxGkaOy4PpCtOBlIaouv4nMlrdZW1Kn008vEMMZzgJlTMoSIptow== Date: Fri, 23 Aug 2024 18:22:40 +0200 From: Miquel Raynal To: Frank Li Cc: Alexandre Belloni , Boris Brezillon , Parshuram Thombare , Greg Kroah-Hartman , Boris Brezillon , Arnd Bergmann , Conor Culhane , linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: Re: [PATCH v3 10/11] i3c: master: svc: wait for Manual ACK/NACK Done before next step Message-ID: <20240823182240.4096619b@xps-13> In-Reply-To: <20240819-i3c_fix-v3-10-7d69f7b0a05e@nxp.com> References: <20240819-i3c_fix-v3-0-7d69f7b0a05e@nxp.com> <20240819-i3c_fix-v3-10-7d69f7b0a05e@nxp.com> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Hi Frank, Frank.Li@nxp.com wrote on Mon, 19 Aug 2024 12:02:04 -0400: > Wait for the controller to complete emitting ACK/NACK, otherwise the next > command may be omitted by the hardware. >=20 > Add command done check at svc_i3c_master_nack(ack)_ibi() and change return a "command done" check in the reutnr type > type to int to indicate wait done timeout. flag possible timeouts. >=20 > Signed-off-by: Frank Li > --- > drivers/i3c/master/svc-i3c-master.c | 31 +++++++++++++++++++++++++------ > 1 file changed, 25 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc= -i3c-master.c > index fbb6cef405577..2010495906eb3 100644 > --- a/drivers/i3c/master/svc-i3c-master.c > +++ b/drivers/i3c/master/svc-i3c-master.c > @@ -384,10 +384,12 @@ static int svc_i3c_master_handle_ibi(struct svc_i3c= _master *master, > return 0; > } > =20 > -static void svc_i3c_master_ack_ibi(struct svc_i3c_master *master, > +static int svc_i3c_master_ack_ibi(struct svc_i3c_master *master, > bool mandatory_byte) > { > unsigned int ibi_ack_nack; > + int ret; > + u32 reg; > =20 > ibi_ack_nack =3D SVC_I3C_MCTRL_REQUEST_IBI_ACKNACK; > if (mandatory_byte) > @@ -396,18 +398,31 @@ static void svc_i3c_master_ack_ibi(struct svc_i3c_m= aster *master, > ibi_ack_nack |=3D SVC_I3C_MCTRL_IBIRESP_ACK_WITHOUT_BYTE; > =20 > writel(ibi_ack_nack, master->regs + SVC_I3C_MCTRL); > + > + ret =3D readl_poll_timeout_atomic(master->regs + SVC_I3C_MSTATUS, reg, > + SVC_I3C_MSTATUS_MCTRLDONE(reg), 1, 1000); Still concerned about the _atomic. > + return ret; return readl... > + > } Otherwise LGTM Reviewed-by: Miquel Raynal Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB9E6C531DC for ; Fri, 23 Aug 2024 16:23:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mjtFUHjoaC4pQJDiMS3U9N5z5+2luGiHWhBFu8YoQZI=; b=uyG6mjmm+wPzwZ aPDaYdL1B/uQZbl4UjQt+kLllXvbkttN5hQhv/7ymfPaysV5EQF7aByLZiJ82oSklRove5+ybD/2T GN72GVd9aFb4p223BlBLynn3/m0GiuHHNi9wgRdV2pJDHqRySRLwHPo0ID5rXI1nbWHFSP7CKjTum TNZHf16OHOaDimDgPUsn+ILqEsueTt24q0bIy7+nF97ZrMTTeDTsUqQyf4vGaBQWusT+MWsHCYvPW SsvBZDyVeDEF4VyNI6ntFgHCShhvjllDOmj5lfTrvOtk459LvUBTnGan3HewJLPom+pVLd3VRyA65 wqAVvYSzPzc46VYJxwSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1shX4H-0000000HXk3-2kQy; Fri, 23 Aug 2024 16:23:17 +0000 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shX3j-0000000HXan-1EZM for linux-i3c@lists.infradead.org; Fri, 23 Aug 2024 16:22:45 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id F22132000A; Fri, 23 Aug 2024 16:22:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1724430161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c6F56iukWQmBKV4FnNA9eGRhnnKZh7f5FQn4pHMuYTo=; b=ayf+nahesCes2xk0GsQMQ2Lp6XTVqom0g0ioc1dzKBHm2CpY+8aXOURfJFfbKDCiW0RJrV eOyZe4VHBpQvrE5stkxdh6dPRhUIIRe4rS6yCNDqcbvk6jyYdzSXts9crXq1UsrULd7TEb etl12fizgZ7EL5WVsLBGSKvh1loDTfofKq3wfU4RH/0o/1StE3hsSTRijFLgVeis6JG5kf fmfDaUVbE3Tu+ruIOiycqNTRiiZi2NwNn6CbJ33ejUVyh6YpJtk7/6xRRSm95hYg6Mc+wu Dz3mWkDBkbsxGkaOy4PpCtOBlIaouv4nMlrdZW1Kn008vEMMZzgJlTMoSIptow== Date: Fri, 23 Aug 2024 18:22:40 +0200 From: Miquel Raynal To: Frank Li Cc: Alexandre Belloni , Boris Brezillon , Parshuram Thombare , Greg Kroah-Hartman , Boris Brezillon , Arnd Bergmann , Conor Culhane , linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: Re: [PATCH v3 10/11] i3c: master: svc: wait for Manual ACK/NACK Done before next step Message-ID: <20240823182240.4096619b@xps-13> In-Reply-To: <20240819-i3c_fix-v3-10-7d69f7b0a05e@nxp.com> References: <20240819-i3c_fix-v3-0-7d69f7b0a05e@nxp.com> <20240819-i3c_fix-v3-10-7d69f7b0a05e@nxp.com> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240823_092243_525155_A8DBF4E1 X-CRM114-Status: GOOD ( 15.16 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org SGkgRnJhbmssCgpGcmFuay5MaUBueHAuY29tIHdyb3RlIG9uIE1vbiwgMTkgQXVnIDIwMjQgMTI6 MDI6MDQgLTA0MDA6Cgo+IFdhaXQgZm9yIHRoZSBjb250cm9sbGVyIHRvIGNvbXBsZXRlIGVtaXR0 aW5nIEFDSy9OQUNLLCBvdGhlcndpc2UgdGhlIG5leHQKPiBjb21tYW5kIG1heSBiZSBvbWl0dGVk IGJ5IHRoZSBoYXJkd2FyZS4KPiAKPiBBZGQgY29tbWFuZCBkb25lIGNoZWNrIGF0IHN2Y19pM2Nf bWFzdGVyX25hY2soYWNrKV9pYmkoKSBhbmQgY2hhbmdlIHJldHVybgoKCWEgImNvbW1hbmQgZG9u ZSIgY2hlY2sgaW4KCnRoZSByZXV0bnIgdHlwZQoKPiB0eXBlIHRvIGludCB0byBpbmRpY2F0ZSB3 YWl0IGRvbmUgdGltZW91dC4KCgkJZmxhZyBwb3NzaWJsZSB0aW1lb3V0cy4KCj4gCj4gU2lnbmVk LW9mZi1ieTogRnJhbmsgTGkgPEZyYW5rLkxpQG54cC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvaTNj L21hc3Rlci9zdmMtaTNjLW1hc3Rlci5jIHwgMzEgKysrKysrKysrKysrKysrKysrKysrKysrKy0t LS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkK PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9pM2MvbWFzdGVyL3N2Yy1pM2MtbWFzdGVyLmMgYi9k cml2ZXJzL2kzYy9tYXN0ZXIvc3ZjLWkzYy1tYXN0ZXIuYwo+IGluZGV4IGZiYjZjZWY0MDU1Nzcu LjIwMTA0OTU5MDZlYjMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9pM2MvbWFzdGVyL3N2Yy1pM2Mt bWFzdGVyLmMKPiArKysgYi9kcml2ZXJzL2kzYy9tYXN0ZXIvc3ZjLWkzYy1tYXN0ZXIuYwo+IEBA IC0zODQsMTAgKzM4NCwxMiBAQCBzdGF0aWMgaW50IHN2Y19pM2NfbWFzdGVyX2hhbmRsZV9pYmko c3RydWN0IHN2Y19pM2NfbWFzdGVyICptYXN0ZXIsCj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKPiAt c3RhdGljIHZvaWQgc3ZjX2kzY19tYXN0ZXJfYWNrX2liaShzdHJ1Y3Qgc3ZjX2kzY19tYXN0ZXIg Km1hc3RlciwKPiArc3RhdGljIGludCBzdmNfaTNjX21hc3Rlcl9hY2tfaWJpKHN0cnVjdCBzdmNf aTNjX21hc3RlciAqbWFzdGVyLAo+ICAJCQkJICAgYm9vbCBtYW5kYXRvcnlfYnl0ZSkKPiAgewo+ ICAJdW5zaWduZWQgaW50IGliaV9hY2tfbmFjazsKPiArCWludCByZXQ7Cj4gKwl1MzIgcmVnOwo+ ICAKPiAgCWliaV9hY2tfbmFjayA9IFNWQ19JM0NfTUNUUkxfUkVRVUVTVF9JQklfQUNLTkFDSzsK PiAgCWlmIChtYW5kYXRvcnlfYnl0ZSkKPiBAQCAtMzk2LDE4ICszOTgsMzEgQEAgc3RhdGljIHZv aWQgc3ZjX2kzY19tYXN0ZXJfYWNrX2liaShzdHJ1Y3Qgc3ZjX2kzY19tYXN0ZXIgKm1hc3RlciwK PiAgCQlpYmlfYWNrX25hY2sgfD0gU1ZDX0kzQ19NQ1RSTF9JQklSRVNQX0FDS19XSVRIT1VUX0JZ VEU7Cj4gIAo+ICAJd3JpdGVsKGliaV9hY2tfbmFjaywgbWFzdGVyLT5yZWdzICsgU1ZDX0kzQ19N Q1RSTCk7Cj4gKwo+ICsJcmV0ID0gcmVhZGxfcG9sbF90aW1lb3V0X2F0b21pYyhtYXN0ZXItPnJl Z3MgKyBTVkNfSTNDX01TVEFUVVMsIHJlZywKPiArCQkJCQlTVkNfSTNDX01TVEFUVVNfTUNUUkxE T05FKHJlZyksIDEsIDEwMDApOwoKU3RpbGwgY29uY2VybmVkIGFib3V0IHRoZSBfYXRvbWljLgoK PiArCXJldHVybiByZXQ7CgoJcmV0dXJuIHJlYWRsLi4uCgo+ICsKPiAgfQoKT3RoZXJ3aXNlIExH VE0KClJldmlld2VkLWJ5OiBNaXF1ZWwgUmF5bmFsIDxtaXF1ZWwucmF5bmFsQGJvb3RsaW4uY29t PgoKVGhhbmtzLApNaXF1w6hsCgotLSAKbGludXgtaTNjIG1haWxpbmcgbGlzdApsaW51eC1pM2NA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWkzYwo=