From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Marcus Hoffmann via buildroot <buildroot@buildroot.org>
Cc: Asaf Kahlon <asafka7@gmail.com>,
James Hilliard <james.hilliard1@gmail.com>,
Marcus Hoffmann <buildroot@bubu1.eu>,
Angelo Compagnucci <angelo.compagnucci@gmail.com>
Subject: Re: [Buildroot] [PATCH 2/2] package/python-can: add option to install the viewer tool
Date: Fri, 23 Aug 2024 19:36:29 +0200 [thread overview]
Message-ID: <20240823193629.6814c1c2@windsurf> (raw)
In-Reply-To: <20240822095953.524686-2-buildroot@bubu1.eu>
On Thu, 22 Aug 2024 11:59:53 +0200
Marcus Hoffmann via buildroot <buildroot@buildroot.org> wrote:
> Enabling the option correctly select the python-curses module dependency
> of the viewer tool.
>
> Signed-off-by: Marcus Hoffmann <buildroot@bubu1.eu>
> ---
> package/python-can/Config.in | 7 +++++++
> package/python-can/python-can.mk | 7 +++++++
> 2 files changed, 14 insertions(+)
>
> diff --git a/package/python-can/Config.in b/package/python-can/Config.in
> index 61955a2b00..36e25b8764 100644
> --- a/package/python-can/Config.in
> +++ b/package/python-can/Config.in
> @@ -11,3 +11,10 @@ config BR2_PACKAGE_PYTHON_CAN
> Python.
>
> https://github.com/hardbyte/python-can
> +
> +config BR2_PACKAGE_PYTHON_CAN_VIEWER
> + bool "python-can-viewer"
> + depends on BR2_PACKAGE_PYTHON_CAN
We normally prefer to enclose package sub-options into a if ... endif
block even when there's only one option, so I adjusted this small
detail and applied to next. Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-08-23 17:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 9:59 [Buildroot] [PATCH 1/2] package/python-can: bump to 4.4.2 Marcus Hoffmann via buildroot
2024-08-22 9:59 ` [Buildroot] [PATCH 2/2] package/python-can: add option to install the viewer tool Marcus Hoffmann via buildroot
2024-08-23 17:36 ` Thomas Petazzoni via buildroot [this message]
2024-08-23 17:35 ` [Buildroot] [PATCH 1/2] package/python-can: bump to 4.4.2 Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240823193629.6814c1c2@windsurf \
--to=buildroot@buildroot.org \
--cc=angelo.compagnucci@gmail.com \
--cc=asafka7@gmail.com \
--cc=buildroot@bubu1.eu \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.