Re: [akpm-mm:mm-unstable 357/379] mm/vma.h:114:19: error: use of undeclared identifier 'USER_PGTABLES_CEILING'

[SeongJae Park <sj@kernel.org>]

Hello,

On Sat, 24 Aug 2024 20:43:25 +0100 Lorenzo Stoakes <lorenzo.stoakes@oracle.com> wrote:

> On Sat, Aug 24, 2024 at 11:14:17PM GMT, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable
> > head:   b659edec079c90012cf8d05624e312d1062b8b87
> > commit: ca39aca8db2d78ff82356defba75d14ce78a67b9 [357/379] mm/vma: track start and end for munmap in vma_munmap_struct
> > config: arm-allnoconfig (https://download.01.org/0day-ci/archive/20240824/202408242348.uGvgH9tt-lkp@intel.com/config)
> > compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 08e5a1de8227512d4774a534b91cb2353cef6284)
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240824/202408242348.uGvgH9tt-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202408242348.uGvgH9tt-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>):
> >
> >    In file included from mm/filemap.c:15:
> >    In file included from include/linux/dax.h:6:
> >    In file included from include/linux/mm.h:2198:
> >    include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
> >      518 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
> >          |                               ~~~~~~~~~~~ ^ ~~~
> >    In file included from mm/filemap.c:52:
> >    In file included from mm/internal.h:13:
> >    include/linux/mm_inline.h:47:41: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
> >       47 |         __mod_lruvec_state(lruvec, NR_LRU_BASE + lru, nr_pages);
> >          |                                    ~~~~~~~~~~~ ^ ~~~
> >    include/linux/mm_inline.h:49:22: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
> >       49 |                                 NR_ZONE_LRU_BASE + lru, nr_pages);
> >          |                                 ~~~~~~~~~~~~~~~~ ^ ~~~
> >    In file included from mm/filemap.c:52:
> >    In file included from mm/internal.h:22:
> > >> mm/vma.h:114:19: error: use of undeclared identifier 'USER_PGTABLES_CEILING'
> >      114 |         vms->unmap_end = USER_PGTABLES_CEILING;
> >          |                          ^
> >    3 warnings and 1 error generated.
> 
> [snip]
> 
> Thanks for the report!
> 
> This is a trivial issue, and can be fixed with the attached fix-patch. This also
> resolves the issue reported in
> https://lore.kernel.org/oe-kbuild-all/202408242304.1A1fXTgE-lkp@intel.com/
> 
> ----8<----
> From 565ad376b0a3aa5822ef479faadff271e90ba51c Mon Sep 17 00:00:00 2001
> From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> Date: Sat, 24 Aug 2024 20:20:17 +0100
> Subject: [PATCH] mm: include linux/pgtable.h in vma_internal.h
> 
> For some arches this is required in order to have access to
> USER_PGTABLES_CEILING and FIRST_USER_ADDRESS.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202408242348.uGvgH9tt-lkp@intel.com/
> Closes: https://lore.kernel.org/oe-kbuild-all/202408242304.1A1fXTgE-lkp@intel.com/
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> ---
>  mm/vma_internal.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/mm/vma_internal.h b/mm/vma_internal.h
> index b930ab12a587..971b13e880c9 100644
> --- a/mm/vma_internal.h
> +++ b/mm/vma_internal.h
> @@ -33,6 +33,7 @@
>  #include <linux/mutex.h>
>  #include <linux/pagemap.h>
>  #include <linux/pfn.h>
> +#include <linux/pgtable.h>
>  #include <linux/rcupdate.h>
>  #include <linux/rmap.h>
>  #include <linux/rwsem.h>
> --
> 2.46.0

Even after applying the above patch, I get similar errors when CONFIG_MMU is
unset[1], as below.  Maybe the case should also be handled?

    In file included from /lib/../mm/internal.h:22:0,
                     from /lib/vsprintf.c:50:
    /lib/../mm/vma.h: In function 'init_vma_munmap':
    /lib/../mm/vma.h:113:21: error: 'FIRST_USER_ADDRESS' undeclared (first use in this function); did you mean 'IFLA_PERM_ADDRESS'?
      vms->unmap_start = FIRST_USER_ADDRESS;
                         ^~~~~~~~~~~~~~~~~~
                         IFLA_PERM_ADDRESS
    /lib/../mm/vma.h:113:21: note: each undeclared identifier is reported only once for each function it appears in
    /lib/../mm/vma.h:114:19: error: 'USER_PGTABLES_CEILING' undeclared (first use in this function)
      vms->unmap_end = USER_PGTABLES_CEILING;
                       ^~~~~~~~~~~~~~~~~~~~~


[1] https://github.com/damonitor/damon-tests/blob/master/corr/tests/build_m68k.sh


Thanks,
SJ