All of lore.kernel.org
 help / color / mirror / Atom feed
From: Binbin Wu <binbin.wu@linux.intel.com>
To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: pbonzini@redhat.com, seanjc@google.com, isaku.yamahata@intel.com,
	rick.p.edgecombe@intel.com, kai.huang@intel.com,
	yuan.yao@linux.intel.com, xiaoyao.li@intel.com,
	binbin.wu@linux.intel.com
Subject: [PATCH v3 0/2] KVM: x86: Check hypercall's exit to userspace generically
Date: Mon, 26 Aug 2024 10:22:53 +0800	[thread overview]
Message-ID: <20240826022255.361406-1-binbin.wu@linux.intel.com> (raw)

Currently in kvm_emulate_hypercall, KVM_HC_MAP_GPA_RANGE is checked
specifically to decide whether a KVM hypercall needs to exit to userspace
or not.  Do the check based on the hypercall_exit_enabled field of
struct kvm_arch.

Also use the API user_exit_on_hypercall() to replace the opencode.

---
v3:
- Rename is_kvm_hc_exit_enabled() to user_exit_on_hypercall(). (Sean)
- Remove the WARN_ON_ONCE(). (Isaku, Sean)
- Use BIT(hc_nr) instead of (1 << nr) (Yuan)
- Added a comment to explain why check the !ret first. (Kai)
- Add Kai and Isaku's Reviewed-by.

v2:
- Check the return value of __kvm_emulate_hypercall() before checking
  hypercall_exit_enabled to avoid an invalid KVM hypercall nr.
  https://lore.kernel.org/kvm/184d90a8-14a0-494a-9112-365417245911@linux.intel.com/
- Add a warning if a hypercall nr out of the range of hypercall_exit_enabled
  can express.

Binbin Wu (2):
  KVM: x86: Check hypercall's exit to userspace generically
  KVM: x86: Use user_exit_on_hypercall() instead of opencode

 arch/x86/kvm/svm/sev.c | 4 ++--
 arch/x86/kvm/x86.c     | 7 ++++---
 arch/x86/kvm/x86.h     | 4 ++++
 3 files changed, 10 insertions(+), 5 deletions(-)


base-commit: a1206bc992c3cd3f758a9b46117dfc7e59e8c10f
-- 
2.46.0


             reply	other threads:[~2024-08-26  2:21 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-26  2:22 Binbin Wu [this message]
2024-08-26  2:22 ` [PATCH v3 1/2] KVM: x86: Check hypercall's exit to userspace generically Binbin Wu
2024-10-09  6:48   ` Xiaoyao Li
2024-10-30 20:49   ` Sean Christopherson
2024-10-31  0:49     ` Huang, Kai
2024-10-31 14:54       ` Sean Christopherson
2024-11-01  2:25         ` Binbin Wu
2024-11-01 15:26           ` Sean Christopherson
2024-11-01 11:05         ` Huang, Kai
2024-11-01 16:39           ` Sean Christopherson
2024-11-01 21:13             ` Huang, Kai
2024-11-04  9:03               ` Binbin Wu
2024-11-04  8:49             ` Binbin Wu
2024-11-04  9:55               ` Huang, Kai
2024-11-05  1:07                 ` Binbin Wu
2024-11-05  2:32                 ` Sean Christopherson
2024-11-05  9:20                   ` Huang, Kai
2024-11-06  8:32                     ` Binbin Wu
2024-11-06  8:54                       ` Huang, Kai
2024-11-06 10:11                         ` Binbin Wu
2024-11-06 15:30                           ` Sean Christopherson
2024-11-25  6:47                             ` Binbin Wu
2024-11-25 12:08                               ` Huang, Kai
2024-10-31  4:56     ` Binbin Wu
2024-10-31 15:11       ` Sean Christopherson
2024-08-26  2:22 ` [PATCH v3 2/2] KVM: x86: Use user_exit_on_hypercall() instead of opencode Binbin Wu
2024-10-09  6:49   ` Xiaoyao Li
2024-10-09  5:37 ` [PATCH v3 0/2] KVM: x86: Check hypercall's exit to userspace generically Binbin Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240826022255.361406-1-binbin.wu@linux.intel.com \
    --to=binbin.wu@linux.intel.com \
    --cc=isaku.yamahata@intel.com \
    --cc=kai.huang@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=seanjc@google.com \
    --cc=xiaoyao.li@intel.com \
    --cc=yuan.yao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.