From: SeongJae Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SeongJae Park <sj@kernel.org>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/4] mm/damon/core: remove per-scheme region priority histogram buffer
Date: Sun, 25 Aug 2024 21:23:22 -0700 [thread overview]
Message-ID: <20240826042323.87025-4-sj@kernel.org> (raw)
In-Reply-To: <20240826042323.87025-1-sj@kernel.org>
Nobody is reading from or writing to the per-scheme region priorities
histogram buffer. It is only wasting memory. Remove it.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
include/linux/damon.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/damon.h b/include/linux/damon.h
index 6342d8f9b0fd..0ac8b862bdcb 100644
--- a/include/linux/damon.h
+++ b/include/linux/damon.h
@@ -242,7 +242,6 @@ struct damos_quota {
unsigned long charge_addr_from;
/* For prioritization */
- unsigned long histogram[DAMOS_MAX_SCORE + 1];
unsigned int min_score;
/* For feedback loop */
--
2.39.2
next prev parent reply other threads:[~2024-08-26 4:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 4:23 [PATCH 0/4] replace per-quota region priorities histogram buffer with per-context one SeongJae Park
2024-08-26 4:23 ` [PATCH 1/4] mm/damon/core: intorduce per-context region priorities histogram buffer SeongJae Park
2024-08-26 4:23 ` [PATCH 2/4] mm/damon/core: replace per-quota regions priority histogram buffer usage with per-context one SeongJae Park
2024-08-26 4:23 ` SeongJae Park [this message]
2024-08-26 4:23 ` [PATCH 4/4] Revert "mm/damon/lru_sort: adjust local variable to dynamic allocation" SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240826042323.87025-4-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.