From: Al Viro <viro@zeniv.linux.org.uk>
To: Yan Zhen <yanzhen@vivo.com>
Cc: brauner@kernel.org, jack@suse.cz, linux-fsdevel@vger.kernel.org,
opensource.kernel@vivo.com
Subject: Re: [PATCH v1] fs: proc: Fix error checking for d_hash_and_lookup()
Date: Mon, 26 Aug 2024 14:49:08 +0100 [thread overview]
Message-ID: <20240826134908.GF1049718@ZenIV> (raw)
In-Reply-To: <20240826090802.2358591-1-yanzhen@vivo.com>
On Mon, Aug 26, 2024 at 05:08:02PM +0800, Yan Zhen wrote:
> The d_hash_and_lookup() function returns either an error pointer or NULL.
>
> It might be more appropriate to check error using IS_ERR_OR_NULL().
Not for procfs it doesn't. Please, don't use that shite.
prev parent reply other threads:[~2024-08-26 13:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 9:08 [PATCH v1] fs: proc: Fix error checking for d_hash_and_lookup() Yan Zhen
2024-08-26 10:39 ` Christian Brauner
2024-08-26 13:49 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240826134908.GF1049718@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=yanzhen@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.