All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Marek Vasut <marek.vasut+renesas@mailbox.org>
Cc: u-boot@lists.denx.de, Linus Walleij <linus.walleij@linaro.org>,
	Lukasz Majewski <lukma@denx.de>,
	Mattijs Korpershoek <mkorpershoek@baylibre.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Nishanth Menon <nm@ti.com>, Zixun LI <admin@hifiphile.com>
Subject: Re: [PATCH 1/6] usb: gadget: Inline usb_add_gadget_udc_release
Date: Mon, 26 Aug 2024 17:47:24 +0200	[thread overview]
Message-ID: <20240826174724.16f0eda8@xps-13> (raw)
In-Reply-To: <20240826143851.8020-1-marek.vasut+renesas@mailbox.org>

Hi Marek,

marek.vasut+renesas@mailbox.org wrote on Mon, 26 Aug 2024 16:38:36
+0200:

> The release parameter of usb_add_gadget_udc_release() is never used.
> The function is never called from anywhere except from a wrapper in
> udc-core.c . Inline the function into the wrapper.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> ---
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Lukasz Majewski <lukma@denx.de>
> Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Zixun LI <admin@hifiphile.com>

LGTM, thanks for the cleanup! Just a minor comment, I would really
appreciate a very succinct cover letter with your overall goal. Would
also be easier for the maintainers to pick-up the tags, like this one.

For the series:

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks!
Miquèl

  parent reply	other threads:[~2024-08-26 15:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-26 14:38 [PATCH 1/6] usb: gadget: Inline usb_add_gadget_udc_release Marek Vasut
2024-08-26 14:38 ` [PATCH 2/6] usb: gadget: Drop usb_udc_release() Marek Vasut
2024-08-29  7:41   ` Mattijs Korpershoek
2024-08-26 14:38 ` [PATCH 3/6] usb: gadget: Track driver data as part of struct usb_gadget Marek Vasut
2024-08-29  7:42   ` Mattijs Korpershoek
2024-08-26 14:38 ` [PATCH 4/6] usb: gadget: Drop dev_to_usb_gadget() Marek Vasut
2024-08-29  7:43   ` Mattijs Korpershoek
2024-08-26 14:38 ` [PATCH 5/6] usb: gadget: dwc2: Drop get/set_udc_gadget_private_data() Marek Vasut
2024-08-29  7:44   ` Mattijs Korpershoek
2024-08-26 14:38 ` [PATCH 6/6] usb: gadget: Pass struct udevice to usb_add_gadget_udc() Marek Vasut
2024-08-29  8:44   ` Mattijs Korpershoek
2024-08-30 22:44   ` Linus Walleij
2024-08-26 15:47 ` Miquel Raynal [this message]
2024-08-29  7:08 ` [PATCH 1/6] usb: gadget: Inline usb_add_gadget_udc_release Mattijs Korpershoek
2024-09-10  8:27 ` Mattijs Korpershoek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240826174724.16f0eda8@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=admin@hifiphile.com \
    --cc=linus.walleij@linaro.org \
    --cc=lukma@denx.de \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=mkorpershoek@baylibre.com \
    --cc=neil.armstrong@linaro.org \
    --cc=nm@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.