Re: [Buildroot] [PATCH 1/1] support/testing: add parted runtime test

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Sun, 25 Aug 2024 13:52:39 +0200
Julien Olivain <ju.o@free.fr> wrote:

> Signed-off-by: Julien Olivain <ju.o@free.fr>
> ---
>  DEVELOPERS                                   |   1 +
>  support/testing/tests/package/test_parted.py | 107 +++++++++++++++++++
>  2 files changed, 108 insertions(+)
>  create mode 100644 support/testing/tests/package/test_parted.py

Thanks, applied to next! Just one comment below.

> +        # For each partition, we create a mount point directory, mount
> +        # the filesystem, copy the reference data file in it, sync the
> +        # filesystem, and compute the sha256 hash of the file. This
> +        # sequence will exercise a bit the partitions and filesystems
> +        # in read/write operations.
> +        for part in range(1, 4):
> +            self.assertRunOk(f"mkdir -p /tmp/MyPart{part}")
> +            self.assertRunOk(f"mount {dev}{part} /tmp/MyPart{part}")
> +            self.assertRunOk(f"cp /tmp/{data_file} /tmp/MyPart{part}/")
> +            self.assertRunOk("sync")

I wasn't sure whether sync or a umount/mount cycle was more appropriate here.

> +            out, ret = self.emulator.run(f"( cd /tmp/MyPart{part} && {hash_cmd} )")

You could have used "cmp" instead to compare files. No need to compute
the hash ahead of time, no need to parse the output of sha256sum, etc:
cmp returns a 0 error code when the files are identical, a non-zero
error code otherwise, so self.assertRunOk() would have worked.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot