From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout2-smtp.messagingengine.com (fout2-smtp.messagingengine.com [103.168.172.145]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4083C13A25B; Tue, 27 Aug 2024 08:13:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.145 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724746422; cv=none; b=cr7lBfyRJ1nATh6cv2OpJtcsUbX4So+4ZThXnKNHu1nyQ//aIQOYqnseadm2VRBIrbalthngkxSvY3jfd8QuvtIZ/NEmL9WjkOyQIom/k0J40o0svfCwc4DsuECyrXMk0grgQINC8Im4K9Ygp1zAh/az8EfVsUWl58B4cfnhPOM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724746422; c=relaxed/simple; bh=CfhXaRPdfpF00dLmUGho2oyCI1F5FmEj8etU3p9RS88=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dr2x2J3bUanMIlWLw/vq6qzsM75B1JdDoozMI9IihGwJUDsz1k4iHwUh9EqgWhxt/VE5NDJbIU0FoNw/YJMYSHKuPxCYa+pUivNIy83Hr2pzIwYaHR7eWLvOdziJlndwwYjpXfyBLYxiP7g0dF5MWRpEjGpRcnpdNyH/wPLfv9o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se; spf=pass smtp.mailfrom=ragnatech.se; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b=klVFeogV; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Z2iEVlU6; arc=none smtp.client-ip=103.168.172.145 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b="klVFeogV"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Z2iEVlU6" Received: from phl-compute-02.internal (phl-compute-02.nyi.internal [10.202.2.42]) by mailfout.nyi.internal (Postfix) with ESMTP id 548D8138AFCD; Tue, 27 Aug 2024 04:13:39 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-02.internal (MEProxy); Tue, 27 Aug 2024 04:13:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech.se; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1724746419; x=1724832819; bh=Bj52+IBQqf17DJDFuJwh8RF0KaDsj5FNtKw9uv5SD08=; b= klVFeogVvc/wX2Wh9eYtm/Xe0a7tnUiVtUM/g29I013SoFV8T/LU6ULmbwCUXXQv VAERy+qDmhbuPdL9haja3YTQcGA1iVy30QmUVUVbhTxQn7wdhQqgI+pPeHUIWENC LyQM6U8ZoWC0wlVeHXd8siDfjBOpDy8LyFi8HxBITzjDrBDl8OG51Uqyj/HEZunz dHHDVRb0nvrTSU7auLnN3VoygshV/fp2wI3h4dCMlC5Ek/DqLkn7nRGHEhNy4BEF Z/PxfQY5ofuGd9C09Z2qPSZdmg889quoMnZR0jid3OGpCLYIFVsa5gWHdCxZskuV +CJAGbUFW8AptMggH6QbvA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1724746419; x= 1724832819; bh=Bj52+IBQqf17DJDFuJwh8RF0KaDsj5FNtKw9uv5SD08=; b=Z 2iEVlU6AySOh+LHy12Eom+8p4KahQALBSjHFN1a0PM4VIzt5m1hysWWBJqspRY/Z jOwZbQJ3MkhWhCbFb1LrTlddanhiENeEuAdE8y4Mr7LN6B8786bbZRUqgOco7Oy4 ftlQ/jvT+tcavlv6ATJAubAZuNPMqWwaTG7E4euMtD7Ts0NQkzmrJhydfg+NDAJX kLzW1a3BX7yhQiVrOPQvAIN9ds9lBW3ZcO2k1UlOO5cn8/MxWSkvRCmzI2RJlBNQ 7mgfs5AZhPCvAAM6Z1RDGnvhz10R0XVP17Rt4LpXK4nTi0ns0pVuQiz/mvahKwxm XqU4XISmULAd1Pg63D9BA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudeftddgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggugfgjsehtkeertddttdej necuhfhrohhmpefpihhklhgrshcuufpnuggvrhhluhhnugcuoehnihhklhgrshdrshhoug gvrhhluhhnugdorhgvnhgvshgrshesrhgrghhnrghtvggthhdrshgvqeenucggtffrrght thgvrhhnpeefhfellefhffejgfefudfggeejlefhveehieekhfeulefgtdefueehffdtvd elieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehn ihhklhgrshdrshhouggvrhhluhhnugdorhgvnhgvshgrshesrhgrghhnrghtvggthhdrsh gvpdhnsggprhgtphhtthhopedutddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohep sghijhhurdgurghsrdhjiiessghprdhrvghnvghsrghsrdgtohhmpdhrtghpthhtohepmh gthhgvhhgrsgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhgruhhrvghnthdrphhi nhgthhgrrhhtsehiuggvrghsohhnsghorghrugdrtghomhdprhgtphhtthhopehrohgshh eskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepkhhriiihshiithhofhdrkhhoiihlohif shhkihdoughtsehlihhnrghrohdrohhrghdprhgtphhtthhopegtohhnohhrodgutheskh gvrhhnvghlrdhorhhgpdhrtghpthhtohepghgvvghrthdorhgvnhgvshgrshesghhlihgu vghrrdgsvgdprhgtphhtthhopehlihhnuhigqdhmvgguihgrsehvghgvrhdrkhgvrhhnvg hlrdhorhhgpdhrtghpthhtohepuggvvhhitggvthhrvggvsehvghgvrhdrkhgvrhhnvghl rdhorhhg X-ME-Proxy: Feedback-ID: i80c9496c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 27 Aug 2024 04:13:37 -0400 (EDT) Date: Tue, 27 Aug 2024 10:13:36 +0200 From: Niklas =?utf-8?Q?S=C3=B6derlund?= To: Biju Das Cc: Mauro Carvalho Chehab , Laurent Pinchart , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , "linux-media@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" Subject: Re: [PATCH v2 4/6] media: rcar-isp: Add family compatible for R-Car Gen4 family Message-ID: <20240827081336.GF2636928@fsdn.se> References: <20240826144352.3026980-1-niklas.soderlund+renesas@ragnatech.se> <20240826144352.3026980-5-niklas.soderlund+renesas@ragnatech.se> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hello Biju, Thanks for your feedback. On 2024-08-26 14:48:07 +0000, Biju Das wrote: > Hi Niklas Söderlund, > > Thanks for the patch. > > > -----Original Message----- > > From: Niklas Söderlund > > Sent: Monday, August 26, 2024 3:44 PM > > Subject: [PATCH v2 4/6] media: rcar-isp: Add family compatible for R-Car Gen4 family > > > > Add the Gen4 family compatible. This will be used instead of a SoC specific compatible for the new > > Gen4 SoC V4M. Two Gen4 boards (V3U and > > V4H) have already been added prior and their bindings need to be kept for backward compatibility. > > > > Signed-off-by: Niklas Söderlund > > --- > > * Changes since v1 > > - Reworked to add a family compatible instead of V4M specific one. > > --- > > drivers/media/platform/renesas/rcar-isp.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/media/platform/renesas/rcar-isp.c b/drivers/media/platform/renesas/rcar-isp.c > > index 4512ac338ca5..6504c7025a40 100644 > > --- a/drivers/media/platform/renesas/rcar-isp.c > > +++ b/drivers/media/platform/renesas/rcar-isp.c > > @@ -429,8 +429,11 @@ static int risp_probe_resources(struct rcar_isp *isp, } > > > > static const struct of_device_id risp_of_id_table[] = { > > + /* Keep to be compatible with old DTS files. */ > > { .compatible = "renesas,r8a779a0-isp" }, > > + /* Keep to be compatible with old DTS files. */ > > { .compatible = "renesas,r8a779g0-isp" }, > > + { .compatible = "renesas,rcar-gen4-isp" }, > > { /* sentinel */ }, > > Nit pick: > Comma can be dropped from last entry. Indeed it could be dropped from the "sentinel" entry, but that would be a different patch. > > Cheers, > Biju > > > }; > > MODULE_DEVICE_TABLE(of, risp_of_id_table); > > -- > > 2.45.2 > > > -- Kind Regards, Niklas Söderlund