Re: [PATCH v4 0/7] fuse: writeback clean up / refactoring

[Josef Bacik <josef@toxicpanda.com>]

On Mon, Aug 26, 2024 at 02:19:01PM -0700, Joanne Koong wrote:
> This patchset contains some minor clean up / refactoring for the fuse
> writeback code.
> 
> As a sanity check, I ran fio to check against crashes -
> ./libfuse/build/example/passthrough_ll -o cache=always -o writeback -o
> source=~/fstests ~/tmp_mount
> fio --name=test --ioengine=psync --iodepth=1 --rw=randwrite --bs=1M --direct=0
> --size=2G --numjobs=2 --directory=/home/user/tmp_mount
> 
> and (suggested by Miklos) fsx test -
> sudo HOST_OPTIONS=fuse.config ./check -fuse generic/616
> generic/616 (soak buffered fsx test) without the -U (io_uring) flag
> (verified this uses the fuse_writepages_fill path)
> 
> v3:
> https://lore.kernel.org/linux-fsdevel/20240823162730.521499-1-joannelkoong@gmail.com/
> Changes from v3 -> v4:
> * Merge v3's 4/9 and 5/9 into 1 patch (Josef)
> * Merge v3's 7/9 and 9/9 into 1 patch
> 
> v2:
> https://lore.kernel.org/linux-fsdevel/20240821232241.3573997-1-joannelkoong@gmail.com/
> Changes from v2 -> v3:
> * Drop v2 9/9 (Miklos)
> * Split v2 8/9 into 2 patches (v3 8/9 and 9/9) to make review easier
> * Change error pattern usage (Miklos)
> 
> v1:
> https://lore.kernel.org/linux-fsdevel/20240819182417.504672-1-joannelkoong@gmail.com/
> Changes from v1 -> v2:
> * Added patches 2 and 4-9
> * Add commit message to patch 1 (Jingbo)

This is good, I've based my folio conversion patches ontop of this series as
well,

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks for this,

Josef