From: Christoph Hellwig <hch@lst.de>
To: Niklas Cassel <cassel@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
Hans Holmberg <Hans.Holmberg@wdc.com>,
Damien Le Moal <dlemoal@kernel.org>,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: fix unintentional splitting of zone append bios
Date: Tue, 27 Aug 2024 14:18:32 +0200 [thread overview]
Message-ID: <20240827121832.GA1607@lst.de> (raw)
In-Reply-To: <Zs278OxdBpn-i9ss@ryzen.lan>
On Tue, Aug 27, 2024 at 01:43:44PM +0200, Niklas Cassel wrote:
> You say that this series fixes code that could affect every submitter of
> zone append bios, thus I am a bit surprised to not see any Fixes-tag(s)
> in any of the patches in this series. Was that intentional?
I'm honestly not sure which exact commit it fixes.
> When was this bug introduced? Or has it been broken since the support for
> zone append was first added?
Possibly.
> Even for a theoretical fix, doesn't this sound serious enough to warrant
> zone append splits to be fixed in stable kernels as well?
I think pretty much every user could hit, at least when manually
dereasing max_sectors.
next prev parent reply other threads:[~2024-08-27 12:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 17:37 fix unintentional splitting of zone append bios Christoph Hellwig
2024-08-26 17:37 ` [PATCH 1/4] block: rework bio splitting Christoph Hellwig
2024-08-26 20:29 ` David Sterba
2024-08-26 22:26 ` Damien Le Moal
2024-08-26 22:37 ` Damien Le Moal
2024-08-27 3:20 ` Christoph Hellwig
2024-08-27 4:08 ` Damien Le Moal
2024-08-26 17:37 ` [PATCH 2/4] block: constify the lim argument to queue_limits_max_zone_append_sectors Christoph Hellwig
2024-08-26 22:27 ` Damien Le Moal
2024-08-26 17:37 ` [PATCH 3/4] block: properly handle REQ_OP_ZONE_APPEND in __bio_split_to_limits Christoph Hellwig
2024-08-26 22:32 ` Damien Le Moal
2024-08-26 17:37 ` [PATCH 4/4] block: don't use bio_split_rw on misc operations Christoph Hellwig
2024-08-26 22:34 ` Damien Le Moal
2024-08-27 11:23 ` fix unintentional splitting of zone append bios Hans Holmberg
2024-08-27 11:43 ` Niklas Cassel
2024-08-27 12:18 ` Christoph Hellwig [this message]
2024-08-29 10:33 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240827121832.GA1607@lst.de \
--to=hch@lst.de \
--cc=Hans.Holmberg@wdc.com \
--cc=axboe@kernel.dk \
--cc=cassel@kernel.org \
--cc=clm@fb.com \
--cc=dlemoal@kernel.org \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.