From: Simon Horman <horms@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Salil Mehta <salil.mehta@huawei.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] net: hisilicon: hip04: fix OF node leak in probe()
Date: Tue, 27 Aug 2024 15:40:10 +0100 [thread overview]
Message-ID: <20240827144010.GD1368797@kernel.org> (raw)
In-Reply-To: <dc803f66-5f85-49d3-81e3-f56a452a71bf@web.de>
On Sun, Aug 25, 2024 at 09:21:31PM +0200, Markus Elfring wrote:
> > Driver is leaking OF node reference from
> > of_parse_phandle_with_fixed_args() in probe().
>
> * Is there a need to improve such a change description another bit?
>
> + Imperative mood
>
> * Tags like “Fixes” and “Cc”
I think it would be helpful if these were either explicitly targeted for
net-next without Fixes tags (the assumed state of affairs as-is).
Subject: [Patch x/n net-next] ...
Or targeted at net, with Fixes tags
Subject: [Patch x/n net] ...
I guess that in theory these are fixes, as resource leaks could occur.
But perhaps that is more theory that practice. I am unsure.
> * Can a corresponding cover letter help?
I agree that would be nice, it's the usual practice for Networking
patchsets with more than one patch.
The above aside, I looked over the code changes
and I agree they are correct.
next prev parent reply other threads:[~2024-08-27 14:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-25 18:53 [PATCH 1/3] net: hisilicon: hip04: fix OF node leak in probe() Krzysztof Kozlowski
2024-08-25 18:53 ` [PATCH 2/3] net: hisilicon: hns_dsaf_mac: fix OF node leak in hns_mac_get_info() Krzysztof Kozlowski
2024-08-25 18:53 ` [PATCH 3/3] net: hisilicon: hns_mdio: fix OF node leak in probe() Krzysztof Kozlowski
2024-08-25 19:21 ` [PATCH 1/3] net: hisilicon: hip04: " Markus Elfring
2024-08-27 14:40 ` Simon Horman [this message]
2024-08-27 14:41 ` Krzysztof Kozlowski
2024-08-27 14:58 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240827144010.GD1368797@kernel.org \
--to=horms@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.