From: Simon Horman <horms@kernel.org>
To: Hongbo Li <lihongbo22@huawei.com>
Cc: David Howells <dhowells@redhat.com>,
johannes@sipsolutions.net, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
allison.henderson@oracle.com, dsahern@kernel.org,
pshelar@ovn.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, rds-devel@oss.oracle.com,
dccp@vger.kernel.org, dev@openvswitch.org,
linux-afs@lists.infradead.org
Subject: Re: [PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code
Date: Tue, 27 Aug 2024 18:58:02 +0100 [thread overview]
Message-ID: <20240827175802.GA1903074@kernel.org> (raw)
In-Reply-To: <1b1ee6e6-ff2e-45d6-bfe2-1f8efaba7b38@huawei.com>
On Mon, Aug 26, 2024 at 10:50:03AM +0800, Hongbo Li wrote:
>
>
> On 2024/8/24 20:06, David Howells wrote:
> > Hongbo Li <lihongbo22@huawei.com> wrote:
> >
> > > - summary.ack_reason = (sp->ack.reason < RXRPC_ACK__INVALID ?
> > > - sp->ack.reason : RXRPC_ACK__INVALID);
> > > + summary.ack_reason = min(sp->ack.reason, RXRPC_ACK__INVALID);
> >
> > Can you use umin() rather than min(), please?
> >
>
> I see reason is u8, so may I use min_t(u8, sp->ack.reason,
> RXRPC_ACK__INVALID)?
I believe that umin was added precisely to avoid such constructions.
See: 80fcac55385c ("minmax: add umin(a, b) and umax(a, b)")
https://git.kernel.org/torvalds/c/80fcac55385c
next prev parent reply other threads:[~2024-08-27 17:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-24 7:40 [PATCH net-next 0/8] Use max/min to simplify the code Hongbo Li
2024-08-24 7:40 ` [PATCH net-next 1/8] net/mac80211: use max " Hongbo Li
2024-08-26 19:02 ` Kalle Valo
2024-08-24 7:40 ` [PATCH net-next 2/8] net/rds: Use max() " Hongbo Li
2024-08-27 5:28 ` Allison Henderson
2024-08-28 13:53 ` Simon Horman
2024-08-24 7:40 ` [PATCH net-next 3/8] net/ipv4: Use min() " Hongbo Li
2024-08-24 7:40 ` [PATCH net-next 4/8] net/core: Use min()/max() " Hongbo Li
2024-08-28 7:36 ` kernel test robot
2024-08-28 8:17 ` kernel test robot
2024-08-28 13:59 ` Simon Horman
2024-08-24 7:40 ` [PATCH net-next 5/8] net/dccp: " Hongbo Li
2024-08-28 14:04 ` Simon Horman
2024-08-24 7:40 ` [PATCH net-next 6/8] net/openvswitch: Use max() " Hongbo Li
2024-08-26 6:37 ` Eelco Chaudron
2024-08-26 17:58 ` [ovs-dev] " Aaron Conole
2024-08-28 14:10 ` Simon Horman
2024-08-24 7:40 ` [PATCH net-next 7/8] net/rxrpc: Use min() " Hongbo Li
2024-08-24 12:06 ` David Howells
2024-08-26 1:41 ` Hongbo Li
2024-08-26 2:50 ` Hongbo Li
2024-08-27 17:58 ` Simon Horman [this message]
2024-08-28 8:17 ` David Howells
2024-08-29 16:46 ` David Laight
2024-08-24 7:40 ` [PATCH net-next 8/8] net/ceph: " Hongbo Li
2024-08-28 14:11 ` Simon Horman
2024-08-26 21:44 ` [PATCH net-next 0/8] Use max/min " Jakub Kicinski
2024-08-27 2:57 ` Hongbo Li
2024-08-27 4:45 ` Kalle Valo
2024-08-27 14:03 ` Jakub Kicinski
2024-08-27 14:31 ` Kalle Valo
2024-08-30 8:40 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240827175802.GA1903074@kernel.org \
--to=horms@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=davem@davemloft.net \
--cc=dccp@vger.kernel.org \
--cc=dev@openvswitch.org \
--cc=dhowells@redhat.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=lihongbo22@huawei.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
--cc=rds-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.