Re: [Buildroot] [PATCH v4 1/1] package/frr: update to 9.1.1

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Mon, 26 Aug 2024 15:19:24 +0200
Vincent Jardin <vjardin@free.fr> wrote:

> Update to the latest 9.x version. Protobuf is now mandatory.
> 
> Thanks to the suggestions from Thomas Petazzoni: Since there is
> a dependency on BR2_PACKAGE_PROTOBUF_C, the dependencies of protobuf_c
> should be imported into FRR's Config.in and the comment should be
> aligned accordingly.
> Note that in order to enable FRR, the following must be enabled
> to support C++:
>  BR2_TOOLCHAIN_BUILDROOT_CXX=y
>  BR2_PACKAGE_FRR=y

This paragraph wasn't really needed, as it's just stating the
"obvious". In addition, it is not true that
BR2_TOOLCHAIN_BUILDROOT_CXX=y is needed. Indeed, this option only
exists if you use an internal/Buildroot toolchain. If you use an
external toolchain, the option name is different. So I simply dropped
this paragraph.

> COPYING hash updated:
> The COPYING file has evolved to expose more details: the respective
> licenses are now listed, except for the GPLv3 license. The GPLv3
> license is only required when FRR is compiled with the GCC plugin
> that extends printf type checks. This plugin should not be enabled
> for production code.
> For more information, see FRR's workflow.rst document.
> 
> Signed-off-by: Vincent Jardin <vjardin@free.fr>
> Suggested-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> 
> frr/Config.in: enable CXX
> 
> Signed-off-by: Vincent Jardin <vjardin@free.fr>

Here you had some left-over from squashing patches I suppose?

I fixed up those minor details, and applied the patch to our next
branch. Thanks a lot for having persisted through 4 iterations!

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot