Re: [PATCH 5/7] drm/i915/display: include media/cec-notifier.h and linux/debugfs.h where needed

[kernel test robot <lkp@intel.com>]

Hi Jani,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-xe/drm-xe-next next-20240827]
[cannot apply to linus/master v6.11-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-i915-wm-move-struct-intel_watermark_params-to-i9xx_wm-c/20240827-003437
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
patch link:    https://lore.kernel.org/r/a9aeb27f0107bdf3d2bd834a48583bc64072447a.1724689818.git.jani.nikula%40intel.com
patch subject: [PATCH 5/7] drm/i915/display: include media/cec-notifier.h and linux/debugfs.h where needed
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20240827/202408271847.dOpt09wa-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240827/202408271847.dOpt09wa-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408271847.dOpt09wa-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/i915/display/hsw_ips.c:321:5: error: expected identifier
     321 |                          "%llu\n");
         |                          ^
>> drivers/gpu/drm/i915/display/hsw_ips.c:318:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
     318 | DEFINE_DEBUGFS_ATTRIBUTE(hsw_ips_debugfs_false_color_fops,
         | ^
         | int
>> drivers/gpu/drm/i915/display/hsw_ips.c:318:25: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
     318 | DEFINE_DEBUGFS_ATTRIBUTE(hsw_ips_debugfs_false_color_fops,
         |                         ^
     319 |                          hsw_ips_debugfs_false_color_get,
     320 |                          hsw_ips_debugfs_false_color_set,
     321 |                          "%llu\n");
         |                                  
         |                                  void
>> drivers/gpu/drm/i915/display/hsw_ips.c:355:2: error: call to undeclared function 'debugfs_create_file'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     355 |         debugfs_create_file("i915_ips_false_color", 0644, crtc->base.debugfs_entry,
         |         ^
   drivers/gpu/drm/i915/display/hsw_ips.c:355:2: note: did you mean 'bus_create_file'?
   include/linux/device/bus.h:126:18: note: 'bus_create_file' declared here
     126 | int __must_check bus_create_file(const struct bus_type *bus, struct bus_attribute *attr);
         |                  ^
>> drivers/gpu/drm/i915/display/hsw_ips.c:356:15: error: use of undeclared identifier 'hsw_ips_debugfs_false_color_fops'
     356 |                             crtc, &hsw_ips_debugfs_false_color_fops);
         |                                    ^
   5 errors generated.


vim +321 drivers/gpu/drm/i915/display/hsw_ips.c

42b4c479025d92 Ville Syrjälä  2023-03-27  317  
42b4c479025d92 Ville Syrjälä  2023-03-27 @318  DEFINE_DEBUGFS_ATTRIBUTE(hsw_ips_debugfs_false_color_fops,
42b4c479025d92 Ville Syrjälä  2023-03-27  319  			 hsw_ips_debugfs_false_color_get,
42b4c479025d92 Ville Syrjälä  2023-03-27  320  			 hsw_ips_debugfs_false_color_set,
42b4c479025d92 Ville Syrjälä  2023-03-27 @321  			 "%llu\n");
42b4c479025d92 Ville Syrjälä  2023-03-27  322  
bc37c98a3d44f7 Jani Nikula    2023-03-02  323  static int hsw_ips_debugfs_status_show(struct seq_file *m, void *unused)
bc37c98a3d44f7 Jani Nikula    2023-03-02  324  {
1fb4da5f7858d7 Ville Syrjälä  2023-03-27  325  	struct intel_crtc *crtc = m->private;
1fb4da5f7858d7 Ville Syrjälä  2023-03-27  326  	struct drm_i915_private *i915 = to_i915(crtc->base.dev);
bc37c98a3d44f7 Jani Nikula    2023-03-02  327  	intel_wakeref_t wakeref;
bc37c98a3d44f7 Jani Nikula    2023-03-02  328  
bc37c98a3d44f7 Jani Nikula    2023-03-02  329  	wakeref = intel_runtime_pm_get(&i915->runtime_pm);
bc37c98a3d44f7 Jani Nikula    2023-03-02  330  
bc37c98a3d44f7 Jani Nikula    2023-03-02  331  	seq_printf(m, "Enabled by kernel parameter: %s\n",
c39fc2aca32a93 Jouni Högander 2023-10-24  332  		   str_yes_no(i915->display.params.enable_ips));
bc37c98a3d44f7 Jani Nikula    2023-03-02  333  
bc37c98a3d44f7 Jani Nikula    2023-03-02  334  	if (DISPLAY_VER(i915) >= 8) {
bc37c98a3d44f7 Jani Nikula    2023-03-02  335  		seq_puts(m, "Currently: unknown\n");
bc37c98a3d44f7 Jani Nikula    2023-03-02  336  	} else {
bc37c98a3d44f7 Jani Nikula    2023-03-02  337  		if (intel_de_read(i915, IPS_CTL) & IPS_ENABLE)
bc37c98a3d44f7 Jani Nikula    2023-03-02  338  			seq_puts(m, "Currently: enabled\n");
bc37c98a3d44f7 Jani Nikula    2023-03-02  339  		else
bc37c98a3d44f7 Jani Nikula    2023-03-02  340  			seq_puts(m, "Currently: disabled\n");
bc37c98a3d44f7 Jani Nikula    2023-03-02  341  	}
bc37c98a3d44f7 Jani Nikula    2023-03-02  342  
bc37c98a3d44f7 Jani Nikula    2023-03-02  343  	intel_runtime_pm_put(&i915->runtime_pm, wakeref);
bc37c98a3d44f7 Jani Nikula    2023-03-02  344  
bc37c98a3d44f7 Jani Nikula    2023-03-02  345  	return 0;
bc37c98a3d44f7 Jani Nikula    2023-03-02  346  }
bc37c98a3d44f7 Jani Nikula    2023-03-02  347  
bc37c98a3d44f7 Jani Nikula    2023-03-02  348  DEFINE_SHOW_ATTRIBUTE(hsw_ips_debugfs_status);
bc37c98a3d44f7 Jani Nikula    2023-03-02  349  
1fb4da5f7858d7 Ville Syrjälä  2023-03-27  350  void hsw_ips_crtc_debugfs_add(struct intel_crtc *crtc)
bc37c98a3d44f7 Jani Nikula    2023-03-02  351  {
1fb4da5f7858d7 Ville Syrjälä  2023-03-27  352  	if (!hsw_crtc_supports_ips(crtc))
1fb4da5f7858d7 Ville Syrjälä  2023-03-27  353  		return;
bc37c98a3d44f7 Jani Nikula    2023-03-02  354  
42b4c479025d92 Ville Syrjälä  2023-03-27 @355  	debugfs_create_file("i915_ips_false_color", 0644, crtc->base.debugfs_entry,
42b4c479025d92 Ville Syrjälä  2023-03-27 @356  			    crtc, &hsw_ips_debugfs_false_color_fops);

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki