From: Jakub Kicinski <kuba@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>, Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
kernel@pengutronix.de, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net-next v3 1/3] phy: open_alliance_helpers: Add defines for link quality metrics
Date: Wed, 28 Aug 2024 13:34:28 -0700 [thread overview]
Message-ID: <20240828133428.4988b44f@kernel.org> (raw)
In-Reply-To: <Zs6spnCAPsTmUfrL@pengutronix.de>
On Wed, 28 Aug 2024 06:50:46 +0200 Oleksij Rempel wrote:
> Considering that you've requested a change to the uAPI, the work has now become
> more predictable. I can plan for it within the task and update the required
> time budget accordingly. However, it's worth noting that while this work is
> manageable, the time spent on this particular task could be seen as somewhat
> wasted from a budget perspective, as it wasn't part of the original scope.
I can probably take a stab at the kernel side, since I know the code
already shouldn't take me more more than an hour. Would that help?
You'd still need to retest, fix bugs. And go thru review.. so all
the not-so-fun parts
> > Especially that we're talking about uAPI, once we go down
> > the string path I presume they will stick around forever.
>
> Yes, I agree with it. I just needed this feedback as early as possible.
Andrew? Do you want to decide? :)
next prev parent reply other threads:[~2024-08-28 20:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 11:59 [PATCH net-next v3 0/3] Add Statistics Support for DP83TG720 PHY Oleksij Rempel
2024-08-22 11:59 ` [PATCH net-next v3 1/3] phy: open_alliance_helpers: Add defines for link quality metrics Oleksij Rempel
2024-08-22 15:48 ` Andrew Lunn
2024-08-26 16:32 ` Jakub Kicinski
2024-08-26 17:12 ` Andrew Lunn
2024-08-26 19:57 ` Jakub Kicinski
2024-08-27 4:51 ` Oleksij Rempel
2024-08-27 18:33 ` Jakub Kicinski
2024-08-28 4:50 ` Oleksij Rempel
2024-08-28 20:34 ` Jakub Kicinski [this message]
2024-08-28 20:45 ` Andrew Lunn
2024-08-29 4:41 ` Oleksij Rempel
2024-08-22 11:59 ` [PATCH net-next v3 2/3] phy: Add defines for standardized PHY generic counters Oleksij Rempel
2024-08-22 15:49 ` Andrew Lunn
2024-08-22 11:59 ` [PATCH net-next v3 3/3] phy: dp83tg720: Add statistics support Oleksij Rempel
2024-08-22 15:49 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240828133428.4988b44f@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.