From: Jakub Kicinski <kuba@kernel.org>
To: David Thompson <davthompson@nvidia.com>
Cc: Benjamin Poirier <benjamin.poirier@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
Asmaa Mnebhi <asmaa@nvidia.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v1] mlxbf_gige: disable port during stop()
Date: Wed, 28 Aug 2024 15:55:48 -0700 [thread overview]
Message-ID: <20240828155548.473b3cd1@kernel.org> (raw)
In-Reply-To: <CY5PR12MB6646FAC499454E380A87D829C7952@CY5PR12MB6646.namprd12.prod.outlook.com>
On Wed, 28 Aug 2024 21:37:06 +0000 David Thompson wrote:
> Hello Jakub and Benjamin, thanks for your input.
>
> I will post a v2 adding information about the "mb()" call.
Perhaps this information you're adding will shed more light..
> Given the above information, does my mlxbf_gige driver patch still need to
> invoke "synchronize_irq()" in the stop() method? The "mlxbf_gige_free_irq()"
> call within the stop() method invokes "free_irq()" for each of the driver's IRQs, so
> sounds like this "synchronize_irq()" is implicitly being invoked?
I was talking about the point in which you add the mb().
IDK what you're trying to protect from but it's after what looks like
disabling IRQ, and there's not free_irq() in that spot.
prev parent reply other threads:[~2024-08-28 22:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 20:48 [PATCH net v1] mlxbf_gige: disable port during stop() David Thompson
2024-08-19 18:55 ` Benjamin Poirier
2024-08-20 0:47 ` Jakub Kicinski
2024-08-28 21:37 ` David Thompson
2024-08-28 22:55 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240828155548.473b3cd1@kernel.org \
--to=kuba@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=asmaa@nvidia.com \
--cc=benjamin.poirier@gmail.com \
--cc=davem@davemloft.net \
--cc=davthompson@nvidia.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.