From: Jakub Kicinski <kuba@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Edward Cree <ecree.xilinx@gmail.com>,
Shen Lichuan <shenlichuan@vivo.com>, <habetsm.xilinx@gmail.com>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-net-drivers@amd.com>,
<linux-kernel@vger.kernel.org>, <opensource.kernel@vivo.com>
Subject: Re: [PATCH v1] sfc: Convert to use ERR_CAST()
Date: Wed, 28 Aug 2024 16:01:32 -0700 [thread overview]
Message-ID: <20240828160132.5553cb1a@kernel.org> (raw)
In-Reply-To: <63d45a76-6ead-4d62-bbca-5b1e3d542f1c@intel.com>
On Wed, 28 Aug 2024 15:31:08 -0700 Jacob Keller wrote:
> Somewhat unrelated but you could cleanup some of the confusion by using
> __free(kfree) annotation from <linux/cleanup.h> to avoid needing to
> manually free ctr in error paths, and just use return_ptr() return the
> value at the end.
Please don't send people towards __free(). In general, but especially as
part of random cleanups.
next prev parent reply other threads:[~2024-08-28 23:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 10:00 [PATCH v1] sfc: Convert to use ERR_CAST() Shen Lichuan
2024-08-28 13:23 ` Edward Cree
2024-08-28 22:31 ` Jacob Keller
2024-08-28 23:01 ` Jakub Kicinski [this message]
2024-08-29 6:47 ` Alejandro Lucero Palau
2024-08-29 15:09 ` Jakub Kicinski
2024-09-02 8:00 ` Alejandro Lucero Palau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240828160132.5553cb1a@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=habetsm.xilinx@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=pabeni@redhat.com \
--cc=shenlichuan@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.