All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Maurizio Lombardi <mlombard@redhat.com>
Cc: hch@lst.de, sagi@grimberg.me, kch@nvidia.com,
	linux-nvme@lists.infradead.org, kbusch@meta.com
Subject: Re: [PATCH] nvmet: Identify-Active Namespace ID List command should reject invalid nsid
Date: Thu, 29 Aug 2024 07:31:29 +0200	[thread overview]
Message-ID: <20240829053129.GA5693@lst.de> (raw)
In-Reply-To: <20240828122129.10788-1-mlombard@redhat.com>

On Wed, Aug 28, 2024 at 02:21:29PM +0200, Maurizio Lombardi wrote:
> +	if (min_nsid >= NVME_NSID_ALL - 1) {

It would almost seem cleaner to check for the two magic constant.
Either way please put a comment in with the spec reference as the code
is rather non-obvious with out.



      reply	other threads:[~2024-08-29  5:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-28 12:21 [PATCH] nvmet: Identify-Active Namespace ID List command should reject invalid nsid Maurizio Lombardi
2024-08-29  5:31 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240829053129.GA5693@lst.de \
    --to=hch@lst.de \
    --cc=kbusch@meta.com \
    --cc=kch@nvidia.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mlombard@redhat.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.