From: Leon Romanovsky <leon@kernel.org>
To: longli@microsoft.com
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Ajay Sharma <sharmaajay@microsoft.com>,
Konstantin Taranov <kotaranov@microsoft.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net] RDMA/mana_ib: fix a bug in calculating the wrong page table index when 64kb page table is used
Date: Thu, 29 Aug 2024 13:24:25 +0300 [thread overview]
Message-ID: <20240829102425.GD26654@unreal> (raw)
In-Reply-To: <1724875569-12912-1-git-send-email-longli@linuxonhyperv.com>
On Wed, Aug 28, 2024 at 01:06:08PM -0700, longli@linuxonhyperv.com wrote:
> From: Long Li <longli@microsoft.com>
>
> MANA hardware uses 4k page size. When calculating the page table index,
> it should use the hardware page size, not the system page size.
>
> Cc: stable@vger.kernel.org
> Fixes: 0266a177631d ("RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter")
> Signed-off-by: Long Li <longli@microsoft.com>
> ---
> drivers/infiniband/hw/mana/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
These two patches are RDMA ones, please fix the target tree, rephrase
the commit title to simplify it and resend.
Thanks
>
> diff --git a/drivers/infiniband/hw/mana/main.c b/drivers/infiniband/hw/mana/main.c
> index d13abc954d2a..f68f54aea820 100644
> --- a/drivers/infiniband/hw/mana/main.c
> +++ b/drivers/infiniband/hw/mana/main.c
> @@ -383,7 +383,7 @@ static int mana_ib_gd_create_dma_region(struct mana_ib_dev *dev, struct ib_umem
>
> create_req->length = umem->length;
> create_req->offset_in_page = ib_umem_dma_offset(umem, page_sz);
> - create_req->gdma_page_type = order_base_2(page_sz) - PAGE_SHIFT;
> + create_req->gdma_page_type = order_base_2(page_sz) - MANA_PAGE_SHIFT;
> create_req->page_count = num_pages_total;
>
> ibdev_dbg(&dev->ib_dev, "size_dma_region %lu num_pages_total %lu\n",
> --
> 2.17.1
>
next prev parent reply other threads:[~2024-08-29 10:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 20:06 [PATCH net] RDMA/mana_ib: fix a bug in calculating the wrong page table index when 64kb page table is used longli
2024-08-28 20:06 ` [PATCH net] RDMA/mana_ib: use the correct page size for mapping user-mode doorbell page longli
2024-08-29 13:53 ` Simon Horman
2024-08-30 0:54 ` Long Li
2024-08-29 10:24 ` Leon Romanovsky [this message]
2024-08-30 0:56 ` [PATCH net] RDMA/mana_ib: fix a bug in calculating the wrong page table index when 64kb page table is used Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240829102425.GD26654@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jgg@ziepe.ca \
--cc=kotaranov@microsoft.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sharmaajay@microsoft.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.