All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: WangYuli <wangyuli@uniontech.com>
Cc: mathias.nyman@intel.com, bhelgaas@google.com,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org, guanwentao@uniontech.com,
	zhanjun@uniontech.com, Chen Baozi <chenbaozi@phytium.com.cn>,
	Wang Zhimin <wangzhimin1179@phytium.com.cn>,
	Chen Zhenhua <chenzhenhua@phytium.com.cn>,
	Wang Yinfeng <wangyinfeng@phytium.com.cn>,
	Jiakun Shuai <shuaijiakun1288@phytium.com.cn>
Subject: Re: [PATCH] usb: xHCI: add XHCI_RESET_ON_RESUME quirk for Phytium xHCI host
Date: Thu, 29 Aug 2024 11:09:48 +0200	[thread overview]
Message-ID: <2024082915-oil-carefully-bdfd@gregkh> (raw)
In-Reply-To: <A2BAFE2C814CDA13+6d47d76e-f0be-4380-bc98-9bd303ac52d6@uniontech.com>

On Thu, Aug 29, 2024 at 04:55:19PM +0800, WangYuli wrote:
> 
> On 2024/8/29 16:46, Greg KH wrote:
> > Please read the top of this file, there's no need to add this id to this
> > file as you are only using it in one .c file.
> 
> Thanks for review.
> 
> More files using PCI_VENDOR_ID_PHYTIUM will appear,though maybe not in the
> USB subsystem.
> 
> These patches are on their way and I won't keep you waiting too long.

When that change happens, then you can add it to the .h file.

> However,if I temporarily delete this line and use a raw hexadecimal value in
> xhci-pci.c,I'll need to modify xhci-pci.c again soon.

Just put the define in xhci-pci.c and all will be fine.

thanks,

greg k-h

  reply	other threads:[~2024-08-29  9:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-29  7:30 [PATCH] usb: xHCI: add XHCI_RESET_ON_RESUME quirk for Phytium xHCI host WangYuli
2024-08-29  8:46 ` Greg KH
2024-08-29  8:55   ` WangYuli
2024-08-29  9:09     ` Greg KH [this message]
2024-08-29  9:38 ` Sergei Shtylyov
2024-08-29 16:51   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024082915-oil-carefully-bdfd@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=bhelgaas@google.com \
    --cc=chenbaozi@phytium.com.cn \
    --cc=chenzhenhua@phytium.com.cn \
    --cc=guanwentao@uniontech.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=shuaijiakun1288@phytium.com.cn \
    --cc=wangyinfeng@phytium.com.cn \
    --cc=wangyuli@uniontech.com \
    --cc=wangzhimin1179@phytium.com.cn \
    --cc=zhanjun@uniontech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.