From: Christian Brauner <brauner@kernel.org>
To: Michal Hocko <mhocko@suse.com>
Cc: Hannes Reinecke <hare@suse.de>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-raid@vger.kernel.org,
linux-kernel@vger.kernel.org, Song Liu <song@kernel.org>,
Yu Kuai <yukuai3@huawei.com>,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] fs: drop GFP_NOFAIL mode from alloc_page_buffers
Date: Fri, 30 Aug 2024 13:01:29 +0200 [thread overview]
Message-ID: <20240830-formel-abklopfen-fa1249f5904d@brauner> (raw)
In-Reply-To: <ZtGTEOEgf4XuUu7F@tiehlicka>
On Fri, Aug 30, 2024 at 11:38:24AM GMT, Michal Hocko wrote:
> On Fri 30-08-24 08:11:00, Hannes Reinecke wrote:
> > On 8/29/24 21:17, Jan Kara wrote:
> > > On Thu 29-08-24 15:06:40, Michal Hocko wrote:
> > > > From: Michal Hocko <mhocko@suse.com>
> > > >
> > > > There is only one called of alloc_page_buffers and it doesn't require
> > > > __GFP_NOFAIL so drop this allocation mode.
> > > >
> > > > Signed-off-by: Michal Hocko <mhocko@suse.com>
> > >
> > > Looks good. Feel free to add:
> > >
> > > Reviewed-by: Jan Kara <jack@suse.cz>
> > >
> > > Although even better fix would be to convert the last remaining caller of
> > > alloc_page_buffers() to folio_alloc_buffers()... But that may be more
> > > difficult.
> > >
> > Already done by Pankajs large-block patchset, currently staged in vfs.git.
>
> Which branch should I be looking at?
Hi Michal, Hannes should be referring to:
https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git/log/?h=vfs.blocksize
next prev parent reply other threads:[~2024-08-30 11:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 13:06 [PATCH] fs: drop GFP_NOFAIL mode from alloc_page_buffers Michal Hocko
2024-08-29 16:34 ` Song Liu
2024-08-29 19:17 ` Jan Kara
2024-08-30 6:11 ` Hannes Reinecke
2024-08-30 9:38 ` Michal Hocko
2024-08-30 11:01 ` Christian Brauner [this message]
2024-08-30 11:31 ` Michal Hocko
2024-08-30 12:54 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240830-formel-abklopfen-fa1249f5904d@brauner \
--to=brauner@kernel.org \
--cc=hare@suse.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=song@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.