All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Willem de Bruijn <willemb@google.com>
Cc: "Michal Koutný" <mkoutny@suse.com>,
	cve@kernel.org, linux-kernel@vger.kernel.org,
	"Tao Liu" <thomas.liu@ucloud.cn>
Subject: Re: CVE-2022-48936: gso: do not skip outer ip header in case of ipip and net_failover
Date: Fri, 30 Aug 2024 12:44:45 +0200	[thread overview]
Message-ID: <2024083005-casualty-earmark-4d57@gregkh> (raw)
In-Reply-To: <CA+FuTSdT9Xf0TZm9JAv5tC3WN0UYO_Y9bcAwSsiKyCtwehOE4g@mail.gmail.com>

On Thu, Aug 29, 2024 at 01:07:36PM -0400, Willem de Bruijn wrote:
> On Thu, Aug 29, 2024 at 12:58 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Thu, Aug 29, 2024 at 12:53:34PM -0400, Willem de Bruijn wrote:
> > > On Thu, Aug 29, 2024 at 12:18 PM Michal Koutný <mkoutny@suse.com> wrote:
> > > >
> > > > On Wed, Aug 28, 2024 at 09:30:08AM GMT, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > > > > > What is the security issue here?
> > > > >
> > > > > This was assigned as part of the import of the Linux kernel GSD entries
> > > > > into CVEs as required by the CVE board of directors (hence the 2022
> > > > > date).  If you don't feel this should be assigned a CVE, just let me
> > > > > know and I will be glad to reject it.
> > > >
> > > > The address of original author bounces back. Willem, could you please
> > > > help explaining context of the change? (~the questions in my previous
> > > > message).
> > >
> > > I don't know why this has a CVE.
> > >
> > > The patch reports that the negative effect is a drop due to a corrupted packet.
> > >
> > > According to the CVE report this requires both user input with
> > > virtio_net_hdr, which is privileged, and a tunnel device configured,
> > > which again is privileged.
> > >
> >
> > Ok, should it be rejected then?  If so, just let me know.
> 
> It is a legitimate bug fix, definitely stable material.
> 
> With the fix backported to all these branches, not sure what, if
> anything, more is needed wrt the CVE.

Ok, for now I'll go revoke this as that feels the safest thing to do at
the moment.

The "frankenkernel" distros can decide if they want to pick this up or
not, everyone sane has had it for years now :)

thanks,

greg k-h

  reply	other threads:[~2024-08-30 10:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-22  3:31 CVE-2022-48936: gso: do not skip outer ip header in case of ipip and net_failover Greg Kroah-Hartman
2024-08-27 15:02 ` Michal Koutný
2024-08-28  7:30   ` Greg Kroah-Hartman
2024-08-29 16:17     ` Michal Koutný
2024-08-29 16:53       ` Willem de Bruijn
2024-08-29 16:58         ` Greg Kroah-Hartman
2024-08-29 17:07           ` Willem de Bruijn
2024-08-30 10:44             ` Greg Kroah-Hartman [this message]
2024-08-30 11:06             ` Michal Koutný

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024083005-casualty-earmark-4d57@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=cve@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkoutny@suse.com \
    --cc=thomas.liu@ucloud.cn \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.