From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Li Ming <ming4.li@intel.com>
Cc: <dave@stgolabs.net>, <dave.jiang@intel.com>,
<alison.schofield@intel.com>, <vishal.l.verma@intel.com>,
<ira.weiny@intel.com>, <dan.j.williams@intel.com>,
<linux-cxl@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] cxl/pci: Rename cxl_setup_parent_dport() and cxl_dport_map_regs()
Date: Fri, 30 Aug 2024 12:03:37 +0100 [thread overview]
Message-ID: <20240830120337.00002479@Huawei.com> (raw)
In-Reply-To: <20240830061308.2327065-1-ming4.li@intel.com>
On Fri, 30 Aug 2024 06:13:06 +0000
Li Ming <ming4.li@intel.com> wrote:
> The name of cxl_setup_parent_dport() function is not clear, the function
> is used to initialize AER and RAS capabilities on a dport, therefore,
> rename the function to cxl_dport_init_ras_reporting(), it is easier for
> user to understand what the function does. Besides, adjust the order of
> the function parameters, the subject of cxl_dport_init_ras_reporting()
> is a cxl dport, so a struct cxl_dport as the first parameter of the
> function should be better.
>
> cxl_dport_map_regs() is used to map CXL RAS capability on a cxl dport,
> using cxl_dport_map_ras() as the function name.
>
> Signed-off-by: Li Ming <ming4.li@intel.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
prev parent reply other threads:[~2024-08-30 11:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 6:13 [PATCH v2 1/3] cxl/pci: Rename cxl_setup_parent_dport() and cxl_dport_map_regs() Li Ming
2024-08-30 6:13 ` [PATCH v2 2/3] cxl/pci: cxl_dport_map_rch_aer() cleanup Li Ming
2024-08-30 6:13 ` [PATCH v2 3/3] cxl/pci: Remove duplicate host_bridge->native_aer checking Li Ming
2024-08-30 11:03 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240830120337.00002479@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=ming4.li@intel.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.