Re: [PATCH v2 1/7] regulator: dt-bindings: mt6323: Convert to DT schema

[Rob Herring <robh@kernel.org>]

On Fri, Aug 30, 2024 at 07:07:26PM +0800, Macpaul Lin wrote:
> Convert this from the old style text based binding to the new DT schema
> style.
> 
> The examples have been trimmed down and move to parent schema
> mfd/mediatek,mt6397.yaml.
> 
> Add new maintainers and submitter from MediaTek.
> 
> Signed-off-by: Sen Chu <sen.chu@mediatek.com>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> ---
>  .../regulator/mediatek,mt6323-regulator.yaml  |  84 +++++++
>  .../bindings/regulator/mt6323-regulator.txt   | 237 ------------------
>  2 files changed, 84 insertions(+), 237 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/regulator/mediatek,mt6323-regulator.yaml
>  delete mode 100644 Documentation/devicetree/bindings/regulator/mt6323-regulator.txt
> 
> Changes for v1 and v2:
>  - This is the first version of converting mt6323-regulator.
>    This is because converting mt6323-regulator together
>    with mfd/mediatek,mt6397.yaml, so we've create a patch set
>    instead of single patch for each skydives.
>  - This patch has been made base on linux-next/master git repo.
> 
> diff --git a/Documentation/devicetree/bindings/regulator/mediatek,mt6323-regulator.yaml b/Documentation/devicetree/bindings/regulator/mediatek,mt6323-regulator.yaml
> new file mode 100644
> index 0000000..f7c2a03
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6323-regulator.yaml
> @@ -0,0 +1,84 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/mediatek,mt6323-regulator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek MT6323 Regulator
> +
> +maintainers:
> +  - John Crispin <john@phrozen.org>
> +  - Sen Chu <sen.chu@mediatek.com>
> +  - Macpaul Lin <macpaul.lin@mediatek.com>
> +
> +description:
> +  Regulator node of the PMIC. This node should under the PMIC's device node.
> +  All voltage regulators provided by the PMIC are described as sub-nodes of
> +  this node.
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: mediatek,mt6323-regulator
> +
> +patternProperties:
> +  "^(buck_)?v(pa|proc|sys)$":
> +    description: Buck regulators
> +    type: object
> +    $ref: regulator.yaml#
> +    properties:
> +      regulator-allowed-modes: false
> +    unevaluatedProperties: false
> +
> +  "^(ldo_)?v(camio|cn18)$":

Why are buck_ and ldo_ prefixes optional? The old binding didn't reflect 
actual (upstream) users? If so, that's fine, but mention that in the 
commit message.

Rob