Re: [PATCH RFC PREVIEW 4/6] iommu: init pasid array while doing domain_replace and iopf is active

[kernel test robot <lkp@intel.com>]

Hi Klaus,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on 3d5f968a177d468cd13568ef901c5be84d83d32b]

url:    https://github.com/intel-lab-lkp/linux/commits/Klaus-Jensen/iommu-vt-d-Separate-page-request-queue-from-SVM/20240826-194355
base:   3d5f968a177d468cd13568ef901c5be84d83d32b
patch link:    https://lore.kernel.org/r/20240826-iopf-for-all-v1-4-59174e6a7528%40samsung.com
patch subject: [PATCH RFC PREVIEW 4/6] iommu: init pasid array while doing domain_replace and iopf is active
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20240830/202408301533.Re9SdBUG-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240830/202408301533.Re9SdBUG-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408301533.Re9SdBUG-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/iommu/iommu.c:3511: warning: Function parameter or struct member 'domain' not described in 'iommu_init_pasid_array'
>> drivers/iommu/iommu.c:3511: warning: Function parameter or struct member 'group' not described in 'iommu_init_pasid_array'
>> drivers/iommu/iommu.c:3511: warning: Function parameter or struct member 'handle' not described in 'iommu_init_pasid_array'


vim +3511 drivers/iommu/iommu.c

  3500	
  3501	/**
  3502	 * iommu_init_pasid_array - Initialize pasid array in the domain group
  3503	 *
  3504	 * Returns 0 on success. Error code on failure
  3505	 *
  3506	 * An IOMMU_NO_PASID element is *NOT* replaced if there is one already there.
  3507	 */
  3508	int iommu_init_pasid_array(struct iommu_domain *domain,
  3509				   struct iommu_group *group,
  3510				   struct iommu_attach_handle *handle)
> 3511	{
  3512		int ret;
  3513	
  3514		if (handle)
  3515			handle->domain = domain;
  3516	
  3517		mutex_lock(&group->mutex);
  3518		ret = xa_insert(&group->pasid_array, IOMMU_NO_PASID, handle, GFP_KERNEL);
  3519		mutex_unlock(&group->mutex);
  3520	
  3521		if (ret == -EBUSY)
  3522			ret = 0;
  3523	
  3524		return ret;
  3525	}
  3526	EXPORT_SYMBOL_NS_GPL(iommu_init_pasid_array, IOMMUFD_INTERNAL);
  3527	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki