From: Simon Horman <horms@kernel.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, linux@armlinux.org.uk,
linux-kernel@vger.kernel.org, o.rempel@pengutronix.de,
p.zabel@pengutronix.de
Subject: Re: [PATCH net-next 1/6] net: ag71xx: add COMPILE_TEST to test compilation
Date: Fri, 30 Aug 2024 19:14:30 +0100 [thread overview]
Message-ID: <20240830181430.GC1368797@kernel.org> (raw)
In-Reply-To: <CAKxU2N_ao94KNa+wZFmx+ZMRjTc5UXD0PgqXF=pb27w93xh9Gw@mail.gmail.com>
On Fri, Aug 30, 2024 at 10:32:08AM -0700, Rosen Penev wrote:
> On Fri, Aug 30, 2024 at 8:49 AM Simon Horman <horms@kernel.org> wrote:
> >
> > On Thu, Aug 29, 2024 at 02:48:20PM -0700, Rosen Penev wrote:
> > > While this driver is meant for MIPS only, it can be compiled on x86 just
> > > fine. Remove pointless parentheses while at it.
> > >
> > > Enables CI building of this driver.
> > >
> > > Signed-off-by: Rosen Penev <rosenp@gmail.com>
> >
> > Thanks, this seems to work well.
> >
> > Reviewed-by: Simon Horman <horms@kernel.org>
> >
> > As a follow-up, could you consider adding a MODULE_DESCRIPTION()
> > to this module. It now gets flagged on x86_64 allmodconfig W=1 builds.
> v2 patchset?
I'd wait to see if this patchset is accepted.
And if so, send a new patch separately.
If not, perhaps add it to v2.
next prev parent reply other threads:[~2024-08-30 18:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 21:48 [PATCH net-next 0/6] various cleanups Rosen Penev
2024-08-29 21:48 ` [PATCH net-next 1/6] net: ag71xx: add COMPILE_TEST to test compilation Rosen Penev
2024-08-30 15:49 ` Simon Horman
2024-08-30 17:32 ` Rosen Penev
2024-08-30 18:14 ` Simon Horman [this message]
2024-08-29 21:48 ` [PATCH net-next 2/6] net: ag71xx: update FIFO bits and descriptions Rosen Penev
2024-08-30 4:54 ` Oleksij Rempel
2024-08-29 21:48 ` [PATCH net-next 3/6] net: ag71xx: use ethtool_puts Rosen Penev
2024-08-30 4:55 ` Oleksij Rempel
2024-08-29 21:48 ` [PATCH net-next 4/6] net: ag71xx: get reset control using devm api Rosen Penev
2024-08-29 21:48 ` [PATCH net-next 5/6] net: ag71xx: remove always true branch Rosen Penev
2024-08-30 4:56 ` Oleksij Rempel
2024-08-29 21:48 ` [PATCH net-next 6/6] net: ag71xx: disable napi interrupts during probe Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240830181430.GC1368797@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.