From: Simon Horman <horms@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, Nikolay Aleksandrov <razor@blackwall.org>,
Andrew Lunn <andrew@lunn.ch>,
corbet@lwn.net, linux-doc@vger.kernel.org
Subject: Re: [PATCH net v2] docs: netdev: document guidance on cleanup.h
Date: Fri, 30 Aug 2024 21:31:09 +0100 [thread overview]
Message-ID: <20240830203109.GB4063074@kernel.org> (raw)
In-Reply-To: <20240830171443.3532077-1-kuba@kernel.org>
On Fri, Aug 30, 2024 at 10:14:42AM -0700, Jakub Kicinski wrote:
> Document what was discussed multiple times on list and various
> virtual / in-person conversations. guard() being okay in functions
> <= 20 LoC is a bit of my own invention. If the function is trivial
> it should be fine, but feel free to disagree :)
>
> We'll obviously revisit this guidance as time passes and we and other
> subsystems get more experience.
>
> Reviewed-by: Eric Dumazet <edumazet@google.com>
> Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: horms@kernel.org
> CC: corbet@lwn.net
> CC: linux-doc@vger.kernel.org
>
> v2:
> - add sentence about revisiting later to commit msg
> - fix spelling
> v1: https://lore.kernel.org/20240829152025.3203577-1-kuba@kernel.org
Thanks. I think this patch has enough tags, so I won't add another.
But, FTR, this version looks good to me.
...
next prev parent reply other threads:[~2024-08-30 20:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 17:14 [PATCH net v2] docs: netdev: document guidance on cleanup.h Jakub Kicinski
2024-08-30 20:31 ` Simon Horman [this message]
2024-09-05 9:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240830203109.GB4063074@kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.