Re: [PATCH -next 08/15] mm: nommu: move sysctl to its own file

[kernel test robot <lkp@intel.com>]

Hi Kaixiong,

kernel test robot noticed the following build errors:

[auto build test ERROR on next-20240826]

url:    https://github.com/intel-lab-lkp/linux/commits/Kaixiong-Yu/mm-vmstat-move-sysctls-to-its-own-files/20240826-200753
base:   next-20240826
patch link:    https://lore.kernel.org/r/20240826120449.1666461-9-yukaixiong%40huawei.com
patch subject: [PATCH -next 08/15] mm: nommu: move sysctl to its own file
config: arm-randconfig-003-20240830 (https://download.01.org/0day-ci/archive/20240830/202408302219.we70LHBV-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 46fe36a4295f05d5d3731762e31fc4e6e99863e9)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240830/202408302219.we70LHBV-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408302219.we70LHBV-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from mm/nommu.c:20:
   In file included from include/linux/mm.h:2168:
   include/linux/vmstat.h:507:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     507 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
   In file included from mm/nommu.c:43:
   In file included from mm/internal.h:13:
   include/linux/mm_inline.h:47:41: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
      47 |         __mod_lruvec_state(lruvec, NR_LRU_BASE + lru, nr_pages);
         |                                    ~~~~~~~~~~~ ^ ~~~
   include/linux/mm_inline.h:49:22: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
      49 |                                 NR_ZONE_LRU_BASE + lru, nr_pages);
         |                                 ~~~~~~~~~~~~~~~~ ^ ~~~
   In file included from mm/nommu.c:43:
   In file included from mm/internal.h:22:
   mm/vma.h:184:19: error: use of undeclared identifier 'USER_PGTABLES_CEILING'
     184 |         vms->unmap_end = USER_PGTABLES_CEILING;
         |                          ^
>> mm/nommu.c:405:2: error: expected ';' after top level declarator
     405 | }
         |  ^
         |  ;
>> mm/nommu.c:417:2: error: call to undeclared function 'register_syscall_init'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     417 |         register_syscall_init("vm", nommu_table);
         |         ^
   mm/nommu.c:417:2: note: did you mean '__register_sysctl_init'?
   include/linux/sysctl.h:232:13: note: '__register_sysctl_init' declared here
     232 | extern void __register_sysctl_init(const char *path, struct ctl_table *table,
         |             ^
   3 warnings and 3 errors generated.


vim +405 mm/nommu.c

   395	
   396	static struct ctl_table nommu_table[] = {
   397		{
   398			.procname	= "nr_trim_pages",
   399			.data		= &sysctl_nr_trim_pages,
   400			.maxlen		= sizeof(sysctl_nr_trim_pages),
   401			.mode		= 0644,
   402			.proc_handler	= proc_dointvec_minmax,
   403			.extra1		= SYSCTL_ZERO,
   404		},
 > 405	}
   406	
   407	/*
   408	 * initialise the percpu counter for VM and region record slabs
   409	 */
   410	void __init mmap_init(void)
   411	{
   412		int ret;
   413	
   414		ret = percpu_counter_init(&vm_committed_as, 0, GFP_KERNEL);
   415		VM_BUG_ON(ret);
   416		vm_region_jar = KMEM_CACHE(vm_region, SLAB_PANIC|SLAB_ACCOUNT);
 > 417		register_syscall_init("vm", nommu_table);
   418	}
   419	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki