From: Peter Zijlstra <peterz@infradead.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ian Rogers <irogers@google.com>,
Kan Liang <kan.liang@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org,
Ravi Bangoria <ravi.bangoria@amd.com>,
Mark Rutland <mark.rutland@arm.com>,
James Clark <james.clark@arm.com>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
Kajol Jain <kjain@linux.ibm.com>,
Thomas Richter <tmricht@linux.ibm.com>,
Atish Patra <atishp@atishpatra.org>,
Palmer Dabbelt <palmer@rivosinc.com>,
Mingwei Zhang <mizhang@google.com>
Subject: Re: [RFC/PATCH 0/4] perf tools: Do not set attr.exclude_guest by default (v1)
Date: Mon, 2 Sep 2024 10:56:28 +0200 [thread overview]
Message-ID: <20240902085628.GA4723@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20240902014621.2002343-1-namhyung@kernel.org>
On Sun, Sep 01, 2024 at 06:46:17PM -0700, Namhyung Kim wrote:
> Hello,
>
> I found perf tools set exclude_guest bit inconsistently. It used to
> set the bit but now the default event for perf record doesn't. So I'm
> wondering why we want the bit in the first place.
>
> Actually it's not good for PMUs don't support any exclusion like AMD
> IBS because it disables new features after the exclude_guest due to
> the missing feature detection logic.
>
> AFAIK it doesn't matter for the most cases but perf kvm. If users
> need to set the bit, they can still use :H modifier. Please let me
> know if it's ok for you.
IIRc the point of setting exclude_guest by default was so that default
perf keeps working in the precense of that PMU pass through mess, no?
next prev parent reply other threads:[~2024-09-02 8:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 1:46 [RFC/PATCH 0/4] perf tools: Do not set attr.exclude_guest by default (v1) Namhyung Kim
2024-09-02 1:46 ` [PATCH 1/4] perf tools: Don't set attr.exclude_guest by default Namhyung Kim
2024-09-02 9:15 ` James Clark
2024-09-02 17:38 ` Namhyung Kim
2024-09-02 1:46 ` [PATCH 2/4] perf tools: Simplify evsel__add_modifier() Namhyung Kim
2024-09-02 1:46 ` [PATCH 3/4] perf stat: Add --exclude-guest option Namhyung Kim
2024-09-02 1:46 ` [PATCH 4/4] perf tools: Do not set exclude_guest for precise_ip Namhyung Kim
2024-09-02 8:56 ` Peter Zijlstra [this message]
[not found] ` <CAM9d7cg13isO4rmwUpDAm9pL7qLYDOfXsBnGhr6eLMuUyM2Z2w@mail.gmail.com>
2024-09-03 8:39 ` [RFC/PATCH 0/4] perf tools: Do not set attr.exclude_guest by default (v1) Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240902085628.GA4723@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=atishp@atishpatra.org \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=mizhang@google.com \
--cc=namhyung@kernel.org \
--cc=palmer@rivosinc.com \
--cc=ravi.bangoria@amd.com \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.