From: Simon Horman <horms@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: cfg80211: wext: Correct spelling in iw_handler.h
Date: Mon, 2 Sep 2024 10:01:04 +0100 [thread overview]
Message-ID: <20240902090104.GA77312@kernel.org> (raw)
In-Reply-To: <dd8cac71a80e70352f4ce4c4da426721e02ff31d.camel@sipsolutions.net>
On Thu, Aug 29, 2024 at 06:07:00PM +0200, Johannes Berg wrote:
> On Thu, 2024-08-29 at 17:03 +0100, Simon Horman wrote:
> > Correct spelling in iw_handler.h.
> > As reported by codespell.
> >
> > Signed-off-by: Simon Horman <horms@kernel.org>
> > ---
> > include/net/iw_handler.h | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/include/net/iw_handler.h b/include/net/iw_handler.h
> > index b2cf243ebe44..f7f4c2a79b9e 100644
> > --- a/include/net/iw_handler.h
> > +++ b/include/net/iw_handler.h
> > @@ -23,7 +23,7 @@
> > * to handle wireless statistics.
> > *
> > * The initial APIs served us well and has proven a reasonably good design.
> > - * However, there is a few shortcommings :
> > + * However, there is a few shortcomings :
>
> If we're going to touch it, maybe that should also say "there are a few
> shortcomings"? :)
Yes, indeed :)
> But is it worth it at all? This stuff is totally on the way out, so all
> the thing about "proven a reasonably good design", well, didn't really
> pan out in practice...
I think if the text is there it may as well be correct.
But if you prefer to leave it as is, then we can drop this topic.
next prev parent reply other threads:[~2024-09-02 9:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 16:03 [PATCH] wifi: cfg80211: wext: Correct spelling in iw_handler.h Simon Horman
2024-08-29 16:07 ` Johannes Berg
2024-09-02 9:01 ` Simon Horman [this message]
2024-09-02 9:11 ` Johannes Berg
2024-09-03 8:25 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240902090104.GA77312@kernel.org \
--to=horms@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.