From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Jan Beulich" <JBeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Frediano Ziglio" <frediano.ziglio@cloud.com>
Subject: [PATCH] x86/boot: Use <xen/types.h>
Date: Mon, 2 Sep 2024 12:59:12 +0100 [thread overview]
Message-ID: <20240902115912.3145737-1-andrew.cooper3@citrix.com> (raw)
... rather than defining them locally. This also covers NULL and *_MAX.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Frediano Ziglio <frediano.ziglio@cloud.com>
---
xen/arch/x86/boot/cmdline.c | 2 ++
xen/arch/x86/boot/defs.h | 17 -----------------
xen/arch/x86/boot/reloc.c | 2 ++
3 files changed, 4 insertions(+), 17 deletions(-)
diff --git a/xen/arch/x86/boot/cmdline.c b/xen/arch/x86/boot/cmdline.c
index b8ad7f3a144a..28a47da7ab02 100644
--- a/xen/arch/x86/boot/cmdline.c
+++ b/xen/arch/x86/boot/cmdline.c
@@ -31,6 +31,8 @@ asm (
);
#include <xen/kconfig.h>
+#include <xen/types.h>
+
#include "defs.h"
#include "video.h"
diff --git a/xen/arch/x86/boot/defs.h b/xen/arch/x86/boot/defs.h
index ee1a4da6af03..cf9a80d116f3 100644
--- a/xen/arch/x86/boot/defs.h
+++ b/xen/arch/x86/boot/defs.h
@@ -20,14 +20,10 @@
#ifndef __BOOT_DEFS_H__
#define __BOOT_DEFS_H__
-#include <xen/stdbool.h>
-
#define __maybe_unused __attribute__((__unused__))
#define __packed __attribute__((__packed__))
#define __stdcall __attribute__((__stdcall__))
-#define NULL ((void *)0)
-
#define ALIGN_UP(arg, align) \
(((arg) + (align) - 1) & ~((typeof(arg))(align) - 1))
@@ -47,17 +43,4 @@
#define tolower(c) ((c) | 0x20)
-typedef unsigned char u8;
-typedef unsigned short u16;
-typedef unsigned int u32;
-typedef unsigned long long u64;
-typedef unsigned int size_t;
-typedef u8 uint8_t;
-typedef u16 uint16_t;
-typedef u32 uint32_t;
-typedef u64 uint64_t;
-
-#define UINT16_MAX ((uint16_t)(~0U))
-#define UINT_MAX (~0U)
-
#endif /* __BOOT_DEFS_H__ */
diff --git a/xen/arch/x86/boot/reloc.c b/xen/arch/x86/boot/reloc.c
index 589e026ff9fb..ac8b58b69581 100644
--- a/xen/arch/x86/boot/reloc.c
+++ b/xen/arch/x86/boot/reloc.c
@@ -26,6 +26,8 @@ asm (
" jmp reloc \n"
);
+#include <xen/types.h>
+
#include "defs.h"
#include <xen/kconfig.h>
--
2.39.2
next reply other threads:[~2024-09-02 11:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 11:59 Andrew Cooper [this message]
2024-09-02 12:07 ` [PATCH] x86/boot: Use <xen/types.h> Jan Beulich
2024-09-02 12:12 ` Andrew Cooper
2024-09-02 12:27 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240902115912.3145737-1-andrew.cooper3@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=frediano.ziglio@cloud.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.