From: Simon Horman <horms@kernel.org>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: alexanderduyck@fb.com, kuba@kernel.org, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, andrew@lunn.ch,
kernel-team@meta.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] eth: fbnic: Fix modpost undefined error
Date: Mon, 2 Sep 2024 20:06:20 +0100 [thread overview]
Message-ID: <20240902190620.GM23170@kernel.org> (raw)
In-Reply-To: <20240902131947.3088456-1-ruanjinjie@huawei.com>
On Mon, Sep 02, 2024 at 09:19:47PM +0800, Jinjie Ruan wrote:
> When CONFIG_FBNIC=m, the following error occurs:
>
> ERROR: modpost: "priv_to_devlink" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> ERROR: modpost: "page_pool_create" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> ERROR: modpost: "devlink_info_serial_number_put" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> ERROR: modpost: "page_pool_alloc_pages" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> ERROR: modpost: "devlink_priv" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> ERROR: modpost: "page_pool_put_unrefed_page" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> ERROR: modpost: "devlink_unregister" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> ERROR: modpost: "devlink_alloc_ns" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> ERROR: modpost: "devlink_register" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> ERROR: modpost: "devlink_free" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
>
> The driver now uses functions exported from a helper module
> but fails to link when the helper is disabled, select them to fix them
>
> Fixes: 546dd90be979 ("eth: fbnic: Add scaffolding for Meta's NIC driver")
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Thanks,
I believe a patch for this problem is already present upstream.
- 9a95b7a89dff ("eth: fbnic: select DEVLINK and PAGE_POOL")
https://git.kernel.org/netdev/net-next/c/9a95b7a89dff
--
pw-bot: not-applicable
next prev parent reply other threads:[~2024-09-02 19:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 13:19 [PATCH] eth: fbnic: Fix modpost undefined error Jinjie Ruan
2024-09-02 19:06 ` Simon Horman [this message]
2024-09-03 3:21 ` Jinjie Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240902190620.GM23170@kernel.org \
--to=horms@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.