From: Nicolas Schier <nicolas@fjasle.eu>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Miguel Ojeda <ojeda@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@lists.linux.dev
Subject: Re: [PATCH v2] kbuild: pahole-version: improve overall checking and error messages
Date: Tue, 3 Sep 2024 21:52:07 +0200 [thread overview]
Message-ID: <20240903-amorphous-impartial-gharial-e8bac8@lindesnes> (raw)
In-Reply-To: <CANiq72kV90EjHGitEVO4GQFYtQJZ_3-1rkXJnOwez7u7Ph+Z3g@mail.gmail.com>
On Mon, Sep 02, 2024 at 06:12:52PM +0200, Miguel Ojeda wrote:
> On Mon, Sep 2, 2024 at 6:09 PM Miguel Ojeda <ojeda@kernel.org> wrote:
> >
> > +if ! command -v "$@" >/dev/null; then
> > + echo >&2 "***"
> > + echo >&2 "*** pahole '$@' could not be found. pahole will not be used."
> > + echo >&2 "***"
> > + exit 1
> > +fi
>
> We may not want to print a warning in this case if this case/setup is
> too common, though.
yes, I think it's a good idea to skip to remove this one.
Kind regards,
Nicolas
next prev parent reply other threads:[~2024-09-03 19:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 16:08 [PATCH v2] kbuild: pahole-version: improve overall checking and error messages Miguel Ojeda
2024-09-02 16:12 ` Miguel Ojeda
2024-09-03 19:52 ` Nicolas Schier [this message]
2024-09-04 2:15 ` Masahiro Yamada
2024-09-03 19:48 ` Nicolas Schier
2024-09-04 0:15 ` Miguel Ojeda
2024-09-04 2:23 ` Masahiro Yamada
2024-09-04 2:04 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240903-amorphous-impartial-gharial-e8bac8@lindesnes \
--to=nicolas@fjasle.eu \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=nathan@kernel.org \
--cc=ojeda@kernel.org \
--cc=patches@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.